This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via 6f7e48d75f7161a4c34f3bf8ececff94b74fbc0b (commit)
via 0471bd6843974b473d266ced3c50b1c95f6695ea (commit)
from 0a5da94a53f9fa2beead2c0bdb791eb723b89817 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 6f7e48d75f7161a4c34f3bf8ececff94b74fbc0b
Author: Jonathan Druart <[email protected]>
Date: Thu Jul 30 11:59:44 2020 +0200
Bug 25852: Add tests
Signed-off-by: Kelly McElligott <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
(cherry picked from commit e330e4ec222f8ac3a04339a020509e30aa0bf3ab)
Signed-off-by: Lucas Gass <[email protected]>
(cherry picked from commit 57e3f2ed7b69e815743d817ac094600d3a40bec8)
Signed-off-by: Aleisha Amohia <[email protected]>
commit 0471bd6843974b473d266ced3c50b1c95f6695ea
Author: Jonathan Druart <[email protected]>
Date: Thu Jul 30 12:00:03 2020 +0200
Bug 25852: Improve C4::Creators::Lib reliability under plack
This is certainly a major issue that leads to many side-effects.
Under plack, the structure of the default values are not handled
correctly.
Package variables are used to store stuff like the "layout type". They
are complex structures (arrays of hashes) and returned without being
copied.
When the caller (the controller script) retrieve them then modify the
returned structures, it actually modifies the package's variables.
One of the issue is:
Create a new layout
The script retrieve a structure with all "selected" flags are set to 0
It select the first one as default (BAR as selected => 1)
The user creates the new layout and will selected BIBBAR (for instance)
If you then edit this new layout, the script will retrieve the
"label_types" and set "selected" for BIBBAR. However BAR is still
selected!
The UI receives 2 selected and display the first selected one that has
the selected option.
Test plan:
1. Create a layout type for Barcode/Biblio
2. Choose fields to print and size of font
3. Save
4. Edit existing Layout
=> Withtout this patch "Barcode" is the preselected option
=> With this patch applied, the correct "Barcode/Biblio" option is
selected
Signed-off-by: Kelly McElligott <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
(cherry picked from commit 0a9d3f17d9e44b5326a42d14420d30243031629d)
Signed-off-by: Lucas Gass <[email protected]>
(cherry picked from commit e2c9fdb5bd702e358aa5b7f86e1ddf80525a4128)
Signed-off-by: Aleisha Amohia <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
C4/Creators/Lib.pm | 16 ++++++++--------
t/db_dependent/Creators/Lib.t | 7 ++++++-
2 files changed, 14 insertions(+), 9 deletions(-)
hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
