This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 3d06cbb55aedc8296b82169a649c7c5dab831101 (commit)
via e7d1ffbad3d517dcf509eec107a54510cca45b64 (commit)
via b255ca7c6eec7be3027e6ade00d8477102062281 (commit)
via 01b65975988e9ec1830499460b078ed1f108656f (commit)
via 5cfbe318d84dbaf1af8699f3e499f2c3e312a7af (commit)
via 0bfe336c7b0a8993411bd45b9e7c66228730f86d (commit)
via 7ee2495f321198548b3ffbf983aa1d13f6c6c2cc (commit)
via 8ede5cd3f93cb96e09f460e1ba965032e804077e (commit)
via 642c29dc230239d4ae1eb718f423c77072aa1e81 (commit)
via 4f3cb59a97df5fc954e9e807896e14af960237a9 (commit)
via 5ece5d7c7f739cbf2d4b81be767ff89a8c1204f5 (commit)
via 22f14a7b6d45f3bf5ad57bd52203d4cdef724ce7 (commit)
via 0310e973a4c28a7e02baad03799eb40869ce4506 (commit)
via f90afe5c22445fb47430f629491d09762beeb3f8 (commit)
via 76cff7e528a673369a0ee1b88207a2dbe4fbf8ad (commit)
via c53909567a31e2eae337ee029d1c9d7348f3874a (commit)
via 55e18646db855a8cf14b1f7f9adae2729525a2ce (commit)
via ad1aab0e4242f4ea774951703796892fb858e6df (commit)
via 342b51629d29db5e9309dc599c67b413e19ebbb8 (commit)
via 4cae9b49f3036c8500db702d031c8475f5fb673b (commit)
via 19c5db66377fc6e30a56f365874387e682e6c4c7 (commit)
via 22abdd8af669dde60211f38f6c27a73367afe910 (commit)
via d1c8d7eccee6e75473bf7c780617d683f64e5229 (commit)
via 3b273de5777ac7dd5bebac629dc8c88e6bdc962a (commit)
via a02bd4f71c25207b38908887bae50bdf1c450a3b (commit)
via 9db369fb58c1f2795f748e972397f1ecb882ce92 (commit)
via 7d78cae2841ee4f60325cb7f31cecce27cab01e4 (commit)
via 1bc7e5a645381ffc30f320624a705869a202c029 (commit)
via 24556e73d279dd5f09e96bc674fcc61fd3cc8fbc (commit)
via e5a959486f1ba8014b2020623cc304711bb856b7 (commit)
via 2baad1a39d72f4cce4f4242753e6c041df410681 (commit)
via 38be70b55d0c01d0d9b54af0ef386d3de90161d7 (commit)
via 692b0958414474b48ef7242b65e697913dc99deb (commit)
via f1c2974d7b3a20d03d7be4df45dde8e8c2d86ff0 (commit)
via 40c5d06a502071f6e9ca3828d37c820855f0c039 (commit)
via 8e397330f687bd0e9e39387e32a8a8acbbb3b31a (commit)
via 89716a78e9a7ed4c80dddba916d52737c7f2b468 (commit)
via 4b3657b3d6762d148b57324c7211ede743c15c5b (commit)
via 99a640fd75118475f5443093a3b815e3ce148b8f (commit)
via 15174e7bd3f03555ff0120385443157f3da39fe2 (commit)
via 4c8b0b9eb65bbdc7ed67c815c2750949de7409cb (commit)
from 51fd1db1cf8ee39d74be436d4bab83955a3c8a18 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3d06cbb55aedc8296b82169a649c7c5dab831101
Author: Jonathan Druart <[email protected]>
Date: Fri Sep 18 11:38:57 2020 +0200
Bug 19889: (follow-up) update DB adjustments
Fix fields order
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit e7d1ffbad3d517dcf509eec107a54510cca45b64
Author: Jonathan Druart <[email protected]>
Date: Fri Sep 18 09:46:10 2020 +0000
Bug 18958: DBRev 20.06.00.039
Signed-off-by: Jonathan Druart <[email protected]>
commit b255ca7c6eec7be3027e6ade00d8477102062281
Author: Nick Clemens <[email protected]>
Date: Tue Aug 25 10:35:02 2020 +0000
Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all
hold types
MapItemsToHoldRequests has three sections: Local holds, item level holds,
bib level holds
Only one of them was setting the reserve_id. This patch makes al three set
it and adds tests
To test:
1 - Repeat test plan on bug
2 - sudo koha-mysql kohadev
SELECT * FROM hold_fill_targets
3 - Ensure reserve_id is set at appropriate times
4 - prove -v t/db_dependent/HoldsQueue.t
Signed-off-by: Marcel de Rooy <[email protected]>
Bug 18958: (QA follow-up) Fix number of tests
In HoldsQueue.t
Signed-off-by: Marcel de Rooy <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 01b65975988e9ec1830499460b078ed1f108656f
Author: Nick Clemens <[email protected]>
Date: Tue Aug 25 09:55:42 2020 +0000
Bug 18958: DBIC schema changes
Signed-off-by: Marcel de Rooy <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 5cfbe318d84dbaf1af8699f3e499f2c3e312a7af
Author: Katrin Fischer <[email protected]>
Date: Sat Aug 22 03:12:36 2020 +0000
Bug 18958: (QA follow-up) Add missing comma to kohastructure.sql
Signed-off-by: Marcel de Rooy <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 0bfe336c7b0a8993411bd45b9e7c66228730f86d
Author: Nick Clemens <[email protected]>
Date: Fri Aug 14 11:06:40 2020 +0000
Bug 18958: Make hold_fill_targets specific to reserves
After looking at Marcel's comments, the problem is in our matching
to hold_fill_targets - rather than adjusting to find filled/waiting holds we
could ensure that hold_fill_targets only refers to the specific hold it
is intended to
This patch is clearer, if slightly less performant than last (we now return
all
the reserves and have to find the 'highest')
Test Plan:
1 - Create and use a patron that can place multiple record level holds per
record
2 - Create a record with X items, each at a different library
3 - Place X 'Next available' holds on the record for the patron using the
'Holds to place' box
4 - perl misc/cronjobs/holds/build_holdsqueue.pl
5 - Check in LibraryA's copy as LibraryA and confirm the hold
6 - Revisit request.pl for the record, notice the next hold in line is now
item-specific
7 - Checkout the item to the patron, notice the remaining hold is marked
waiting
8 - Attempt to place another hold for your patron, notice that it requires
an item-specific hold
8 - Apply this patch
9 - Repeat steps 1-5
10 - Revisit request.pl for the record, notice the next hold in line has
*not* become item-specific
11 - Checkout the item to the patron, ensure the first hold is filled and
the second remains record level
12 - Repeat whole test plan without building holds queue to confirm holds
are still treated correctly
Signed-off-by: Andrew Fuerste-Henry <[email protected]>
Signed-off-by: Marcel de Rooy <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 7ee2495f321198548b3ffbf983aa1d13f6c6c2cc
Author: Nick Clemens <[email protected]>
Date: Mon Aug 12 18:41:24 2019 +0000
Bug 18958: Unit tests
Signed-off-by: Bonnie Gardner <[email protected]>
Signed-off-by: Bouzid Fergani <[email protected]>
Signed-off-by: Kyle M Hall <[email protected]>
Signed-off-by: Andrew Fuerste-Henry <[email protected]>
Signed-off-by: Marcel de Rooy <[email protected]>
JD amended patch: perltidy and simplify item/biblio creation
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 8ede5cd3f93cb96e09f460e1ba965032e804077e
Author: Joonas Kylmälä <[email protected]>
Date: Mon Sep 14 10:27:24 2020 +0300
Bug 26448: Don't overwrite commit parameter passed to koha-elasticsearch
The "--commit" or "-c" parameter was incorrectly not used if it was
passed to the koha-elasticsearch program.
To test:
1) Before patch notice koha-elasticsearch --rebuild --commit 1 -v <instance>
only commits every 5000 records
2) Apply patch and notice the above command commits every 1 record
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 642c29dc230239d4ae1eb718f423c77072aa1e81
Author: Andreas Roussos <[email protected]>
Date: Mon Sep 14 10:08:23 2020 +0200
Bug 26451: fix typo in bulkmarcimport.pl
bulkmarcimport.pl displays a small typo when a MARC modification
template is being used: "modofication".
This patch fixes that.
Test plan: apply the patch, and confirm the script no longer
displays the typo.
Signed-off-by: Owen Leonard <[email protected]>
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 4f3cb59a97df5fc954e9e807896e14af960237a9
Author: Katrin Fischer <[email protected]>
Date: Thu Aug 27 07:30:54 2020 +0000
Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal
While these may not make sense for all patron field preferences, I think
it's better to have them in general than to have them missing.
To test:
- Check the modal for BorrowerMandatoryField system preference
- Verify dateenrolled and dateexpiry fields are missing
- Apply patch
- Verify the dates are listed now
- Set both to mandatory
- Verify that they are indeed mandatory when adding a new patron now
Signed-off-by: David Nind <[email protected]>
Signed-off-by: Julian Maurice <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 5ece5d7c7f739cbf2d4b81be767ff89a8c1204f5
Author: Owen Leonard <[email protected]>
Date: Wed Sep 9 15:58:04 2020 +0000
Bug 26421: Use Bootstrap screen reader text class for shelf browser messages
This patch udpates the markup added by Bug 26039, replacing the "hidden"
class, which is no longer functional with Bootstrap 4, with "sr-only," a
class designed specifically for screen reader text.
The patch also corrects a typo, "shelfbrowers" -> "shelf browser"
To test, apply the patch and make sure the OPACShelfBrowser system
preference is enabled.
View the detail page for a bibliographic record with items. In the
holdings table, you should see links labeled "Browse shelf."
When you open the shelf browser there should be a link at the top that
reads "Close shelf browser."
If you have access to a screen reader, test that the hidden text is
announced by the reader. "Browse shelf (Opens below)" and "Close shelf
browser (Hides shelf browser)."
Signed-off-by: Stina Hallin <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 22f14a7b6d45f3bf5ad57bd52203d4cdef724ce7
Author: Marcel de Rooy <[email protected]>
Date: Tue Sep 15 12:09:56 2020 +0000
Bug 26464: Code correction in opac-main when news_id passed
Theoretical change. If somehow the search would return more than one
result, the code is wrong.
The if test can be simplified: remove scalar and >0.
We should not pass @array to one param. It would theoretically add wrong
items or
trigger an odd number warning. If it is only one, it is no problem. But it
is buggy.
Test plan:
Pass an existing news_id to opac-main. Item visible?
And pass a not-existing. Error message?
Signed-off-by: Marcel de Rooy <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 0310e973a4c28a7e02baad03799eb40869ce4506
Author: Jonathan Druart <[email protected]>
Date: Fri Jul 31 11:15:57 2020 +0200
Bug 10921: Prevent an order from a closed basket to be edited
We don't allow editing of orders that are part of a closed basket, but
we don't enforce the rule in the controller file.
This patch use output_and_exit to stop the script and display an error
to the end user.
Test plan:
Create a basket, add an order
On the basket view you see the "Modify" link, open it in a separate tab
=> You can edit the basket
Keep this tab open, get back to the other one and close the basket
Reload the tab with the order edition form
=> You cannot longer edit the basket
QA: Do we need a check in addorder.pl as well?
Signed-off-by: Henry Bolshaw <[email protected]>
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit f90afe5c22445fb47430f629491d09762beeb3f8
Author: Owen Leonard <[email protected]>
Date: Mon Jul 13 17:42:36 2020 +0000
Bug 15933: Add cataloguing plugin to search for existing publishers in
other records
This patch adds a new cataloging plugin for MARC21 installations,
marc21_field-260b.pl. When enabled it provides autocomplete for
publisher name, pulling existing data from biblioitems.publishercode.
To test, apply the patch and enable the plugin:
- Go to Administration -> MARC bibliographic framework -> MARC structure
-> 260 -> Edit subfields -> Subfield b -> Other options.
- Set "Plugin" to marc21_field_260b.pl.
- Go to Cataloging and edit or create a record.
- Under tab 2 click the field for 260$b. Start typing a publisher name.
A dropdown should appear with matching publishers.
- Selecting one of the results should populate the form field with that
information.
Signed-off-by: Sally <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Also works with 264$b.
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 76cff7e528a673369a0ee1b88207a2dbe4fbf8ad
Author: Jonathan Druart <[email protected]>
Date: Fri Sep 18 09:46:10 2020 +0000
Bug 24807: DBRev 20.06.00.038
Signed-off-by: Jonathan Druart <[email protected]>
commit c53909567a31e2eae337ee029d1c9d7348f3874a
Author: Nick Clemens <[email protected]>
Date: Fri Jul 10 13:15:58 2020 +0000
Bug 24807: (follow-up) Add support for spaces as unknown characters
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 55e18646db855a8cf14b1f7f9adae2729525a2ce
Author: Nick Clemens <[email protected]>
Date: Thu May 7 16:26:38 2020 +0000
Bug 24807: (follow-up) Fix spelling
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit ad1aab0e4242f4ea774951703796892fb858e6df
Author: David Gustafsson <[email protected]>
Date: Mon Apr 20 13:03:24 2020 +0200
Bug 24807: Simplify with new and imporved value_callbacks
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 342b51629d29db5e9309dc599c67b413e19ebbb8
Author: David Gustafsson <[email protected]>
Date: Thu Apr 16 17:26:41 2020 +0200
Bug 24807: Refactor using tokenize_callbacks
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 4cae9b49f3036c8500db702d031c8475f5fb673b
Author: Nick Clemens <[email protected]>
Date: Wed Apr 8 09:55:20 2020 +0000
Bug 24807: Add suppport for uncertain fields and ranges
To test:
1 - Have some records with uncertain dates in the 008
19uu, 195u, etc.
2 - Index them in Elasticsearch
3 - Do a search that will return them
4 - Sort results by publication/copyright date
5 - Note odd results
6 - Apply patch
7 - Reindex
8 - Sorting should be improved
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 19c5db66377fc6e30a56f365874387e682e6c4c7
Author: David Gustafsson <[email protected]>
Date: Thu Apr 16 14:51:13 2020 +0200
Bug 24807: Update tests
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 22abdd8af669dde60211f38f6c27a73367afe910
Author: David Gustafsson <[email protected]>
Date: Thu Mar 5 11:35:32 2020 +0100
Bug 24807: Add database update script
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit d1c8d7eccee6e75473bf7c780617d683f64e5229
Author: David Gustafsson <[email protected]>
Date: Wed Mar 4 17:07:11 2020 +0100
Bug 24807: Add "year" type to improve sorting behaviour
Add a "year" search field type. Fields with this type will only
retain values that looks like years, so invalid values such as
whitespace or word characters will not be indexed.
This for instance improves the behaviour when sorting by
"date-of-publication". If all values are indexed, records with
junk data instead of valid years will appear first among the search
results, drowning out more relevant hits. If assigning this field
the "year" type these records will instead always appear last,
regarless of sort order.
To test:
1) Have at least two biblios, one with a valid year in 008 (pos 7-10)
and another with an invalid one ("uuuu" for example)
2) Perform a wildcard search (*) and sort results by publication date.
3) The record with invalid year of pulication in 008 should appear first
4) Apply patch and run database updates
5) Reindex ElasticSearch
6) Perform the same search as in 2)
7) The record with the invalid year should now appear last
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 3b273de5777ac7dd5bebac629dc8c88e6bdc962a
Author: Lucas Gass <[email protected]>
Date: Thu Aug 6 18:21:52 2020 +0000
Bug 25744: replace <b> with <strong> in the staff interface
This patch set attempts to replace all the <i> tags with <em> and all
the <b> tags with <strong> in the staff interface.
I attempted to get all the templates, includes, and xslt files.
To test:
1. Review the changes as best as possible, looking for mistakes.
2. grep for <i> and <b> in the modules, includes, and xslt folders. You
should get nothing/
3. If you grep '<\/i>' you should only see instances of Font Awesome.
4. If you grep '<\/b>' you should only see instances where caret is used.
Signed-off-by: Owen Leonard <[email protected]>
Signed-off-by: Julian Maurice <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit a02bd4f71c25207b38908887bae50bdf1c450a3b
Author: Lucas Gass <[email protected]>
Date: Thu Aug 6 17:29:54 2020 +0000
Bug 25744: Replace <i> with <em> in staff interface
Signed-off-by: Owen Leonard <[email protected]>
Signed-off-by: Julian Maurice <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 9db369fb58c1f2795f748e972397f1ecb882ce92
Author: Fridolin Somers <[email protected]>
Date: Thu Jul 23 10:21:36 2020 +0200
Bug 26049: Replace li with span class results_summary in UNIMARC intranet
XSLT
In all XSLT for record display, fields are created with <span
class="results_summary> except in UNIMARC intranet where there is just <li>.
This allows a better CSS customisation and closer code in files for OPAC
and intranet.
Actually li gets diplayed with a dot at each line, we don't want this.
Test plan :
1) For each modified file run 'xsltproc file.xsl' and see there is no
error
2) Use default XSLT in all system preferences
3) Perform a search and check display with and without patch
4) Click on a record to see details and check display with and without patch
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 7d78cae2841ee4f60325cb7f31cecce27cab01e4
Author: Owen Leonard <[email protected]>
Date: Mon Aug 31 12:33:19 2020 +0000
Bug 26262: (follow-up) Fix course details page, default configuration
Bug 25287 changed the default DataTable configuration in the OPAC so
that tables are paginated by default. This is inconsistent with the way
we currently use DataTables in the OPAC, and the change was probably
unintentional. This patch returns the default pagination configuration
to what it was before: Off.
The patch also updates opac-course-details.tt with the same DOM
configuration as opac-course-reserves.tt.
To test, apply the patch and view the list of course reserves and the
list of titles attached to a course. In both cases there should be no
pagination controls, and the tables should show all results.
Signed-off-by: Alexis Ripetti <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 1bc7e5a645381ffc30f320624a705869a202c029
Author: Tomas Cohen Arazi <[email protected]>
Date: Wed Aug 26 12:41:47 2020 -0300
Bug 26262: Remove wrong dom setting in course reserves (OPAC)
The current setting required pagination to be displayed. This was hidden
probably as a side effect of styling settings. But the docs are clear on
the fact that p and l are intended for displaying pagination controls
and table rows lenght information [1]
As the course reserves datatable is not paginated, this needs to be
fixed properly by removing those controls in the configuration. This
patch does so.
To test:
1. Have some course reserves
2. See them in the OPAC
=> FAIL: Some funky, misaligned pagination artifacts are displayed
3. Apply this patch and reload
=> SUCCESS: Things are back to normal!
4. Sign off :-D
[1] https://datatables.net/examples/basic_init/dom.html
Signed-off-by: Tomas Cohen Arazi <[email protected]>
Signed-off-by: Owen Leonard <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 24556e73d279dd5f09e96bc674fcc61fd3cc8fbc
Author: David Cook <[email protected]>
Date: Wed Aug 26 07:35:36 2020 +0000
Bug 26301: Use CanBookBeRenewed when renewing via self-checkout
Currently, if you have OverduesBlockCirc set to "Ask for confirmation"
and OverduesBlockRenewing set to "allow renewing", you get caught
in a loop where you can never renew an overdue material.
This patch uses CanBookBeRenewed for renewals, rather than CanBookBeIssued,
which means the correct rules are applied to the correct scenario.
To test:
a. Set OverduesBlockCirc to "Ask for confirmation"
b. Ensure "OverduesBlockRenewing" set to "allow renewing"
0. Apply the patch
1. Checkin item barcode 3999900000001
2. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
3. Checkout item barcode 3999900000001 to 1 year ago
4. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl
5. Login as the "koha" user
6. Click on "Renew item"
7. Note that the item is renewed
8. Checkin item barcode 3999900000001
9. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
10. Checkout item barcode 3999900000001 to 1 year ago
11. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl
12. Login as the "koha" user
13. Type "3999900000001" into the box under "Scan a new item or enter its
barcode"
14. Click "Submit"
15. Note the system says the item is already checked out and it prompts
you to click "Renew item" in this screen
16. Click "Renew item"
17. Note the system says "Item renewed" near the top of the screen, and the
"Due"
date near the bottom of the screen is more recent than the original due date
18. Checkin item barcode 3999900000001
19. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl
20. Login as the "koha" user
21. Type "3999900000001" into the box under "Scan a new item or enter its
barcode"
22. Click "Submit"
23. Note the system says "Item checked out" and the item appears in the
checkouts
at the bottom of the screen
Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit e5a959486f1ba8014b2020623cc304711bb856b7
Author: Katrin Fischer <[email protected]>
Date: Sat Sep 12 17:53:26 2020 +0000
Bug 26435: (QA follow-up) Terminology: Fix some more borrowers in other
preferences
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 2baad1a39d72f4cce4f4242753e6c041df410681
Author: Katrin Fischer <[email protected]>
Date: Sat Sep 12 17:51:52 2020 +0000
Bug 26435: (QA follow-up) Fix terminology: borrower to patron in new hint
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 38be70b55d0c01d0d9b54af0ef386d3de90161d7
Author: Andrew Fuerste-Henry <[email protected]>
Date: Fri Sep 11 15:39:53 2020 +0000
Bug 26435: Add warning to AutoSelfCheck sysprefs
To test:
1- apply patch, restart
2- look up AutoSelfCheck sysprefs
3- confirm new note in description
Signed-off-by: Lucas Gass <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 692b0958414474b48ef7242b65e697913dc99deb
Author: Nick Clemens <[email protected]>
Date: Mon Sep 14 17:44:36 2020 +0000
Bug 26460: Fix line ending in JSON
Wrong line ending in JSON causes error:
Uncaught SyntaxError: missing } after property list
note: { opened at line 29579, column 15
To test:
1 - Have a title with some items not for hold in staff interface
2 - Set AllowHoldPolicyOverride to 'Allow'
3 - Attempt to place hold on the title
4 - Note JS error in the console and datatable does not load for items
5 - Apply patch
6 - Reload
7 - Error is cleared, table loads correctly
Signed-off-by: David Nind <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit f1c2974d7b3a20d03d7be4df45dde8e8c2d86ff0
Author: Nick Clemens <[email protected]>
Date: Fri Sep 4 16:16:27 2020 +0000
Bug 25969: Don't set itemnumber as reserve->itemnumber
When a hold is checked in at the wrong destination we revert the found
status
For a title level hold this means we return it to a title level hold, with
no itemnumber
When we checkin the item we find the hold, but won't set the itemnumber in
the hold until it is confirmed
In the script we were setting the itemnumber param, but then setting it
again using the reserve itemnumber.
In all conditions before the itemnumber has been set, we don't need to set
it again, especially when we do
so incorrectly
To test:
- Log in at Library A
- Place hold on item at Library A, for pickup at Library A
- Check item in at Library A
- Click "Confirm hold"
- Set library to Library B
- Check item in again (try with both the box on reutrns.pl and the box in
the header)
- Click "Confirm hold and transfer"
- get error: Can't call method "biblio" on an undefined value at
/kohadevbox/koha/circ/returns.pl line 147
- apply patch
- repeat
- success!
- confirm trappings of holds works as normally otherwise too
Signed-off-by: Daniel Gaghan <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 40c5d06a502071f6e9ca3828d37c820855f0c039
Author: Kyle M Hall <[email protected]>
Date: Thu Jul 9 14:36:31 2020 -0400
Bug 25969: Checking in a found hold at a different branch then confirming
the hold causes internal server error
If a record level hold is filled and waiting at Library A, and the item
is checked in at Library B, and an attempt is made to re-fill the hold
with the item, Koha will return an ISE.
Test Plan:
1) Place a hold for Library A, at Library A, for pickup at Library A
2) Check in the item at Library A and fill the hold so it is waiting at
Library A
3) Log in as Library B, check in the same barcode
4) Note the request to fill the hold with the item
5) Choose to fill the hold
6) Note you get an internal server error
7) Apply this patch
8) Restart all the things!
9) Repeat steps 1-5
10) No ISE!
Signed-off-by: Daniel Gaghan <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 8e397330f687bd0e9e39387e32a8a8acbbb3b31a
Author: Jonathan Druart <[email protected]>
Date: Thu Sep 10 09:42:58 2020 +0200
Bug 26420: Use translated notices for overdue_notices.pl
This script does not pass the patron's preferred lang for notices.
Test plan:
Enable TranslateNotices
Create a patron with a preferred lang for notices != default
Translate ODUE for this language
Setup the overdue notices for this patron's category
Check an item out for this patron (select the correct due date to
trigger the notice)
Run the script overdue_notices.pl
Check the message_queue table and confirm that the notice enqueued is
translated
Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 89716a78e9a7ed4c80dddba916d52737c7f2b468
Author: Martin Renvoize <[email protected]>
Date: Wed Sep 16 11:02:22 2020 +0100
Bug 26269: Fix variable name mismatch for cash_register in paycollect
It appears that through various rebases the variable names in the form
and the controller script have become mismatched. This patch corrects
the situation and clarifies their intended use.
Test plan:
1/ Turn on cash registers in sysprefs
2/ Define at least 2 cash registers in Admin
3/ Create a manual invoice on a patron
4/ Pay off half of your fee, selecting the first register
5/ Pay off the remaining fee, selecting the second register
6/ Query accountlines.register_id for your two payments
8/ Confirm the two accountlines.register_id's do not match (thus the
passed variable was used)
https://bugs.koha-community.org/show_bug.cgi?id=26469
Signed-off-by: Jessie Zairo <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 4b3657b3d6762d148b57324c7211ede743c15c5b
Author: Tomas Cohen Arazi <[email protected]>
Date: Tue Sep 15 16:23:05 2020 -0300
Bug 26470: Store the item before calling the after action hook
This patch makes Koha::Item->store call $self->SUPER::store before
calling the hook, so things like the itemnumber (AUTO_INCREMENT field)
are available to the plugin hook.
It does so by storing the output on a temporary variable, to keep the
current behaviour of just returning the output from SUPER::store.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t \
t/db_dependent/Koha/Item.t \
t/db_dependent/Koha/Items.t
=> FAIL: the hooks tests fail. Item.t hasn't been altered so should pass
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass! Item.t as well! (i.e. no behaviour change)
5. Sign off :-D
Signed-off-by: David Nind <[email protected]>
Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 99a640fd75118475f5443093a3b815e3ce148b8f
Author: Tomas Cohen Arazi <[email protected]>
Date: Tue Sep 15 16:21:33 2020 -0300
Bug 26470: Regression tests
This patch tweaks the test plugin so it composes an exception based on
the fact that the hook was called with the item and item_id parameters
defined.
It then makes the tests expect a specific exception message with
information about this.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
=> FAIL: Tests fail!
Signed-off-by: David Nind <[email protected]>
Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 15174e7bd3f03555ff0120385443157f3da39fe2
Author: Fridolin Somers <[email protected]>
Date: Tue Sep 8 16:54:19 2020 +0200
Bug 26407: fix query in 'title exists' in
`search_for_data_inconsistencies.pl`
Bug 23871 added check for 'title exists' to
`search_for_data_inconsistencies.pl`.
There is a typo in DBIx query to create or : hashref instead of arrayref.
Test plan :
1) Change title of biblio record XXX in SQL :
UPDATE biblio SET title = '' WHERE biblionumber=XXX
2) Change title of biblio record YYY in SQL :
UPDATE biblio SET title = NULL WHERE biblionumber=YYY
3) Run misc/maintenance/search_for_data_inconsistencies.pl
4) Check you see both records
Signed-off-by: David Nind <[email protected]>
Signed-off-by: Nick Clemens <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
Signed-off-by: Jonathan Druart <[email protected]>
commit 4c8b0b9eb65bbdc7ed67c815c2750949de7409cb
Author: Jonathan Druart <[email protected]>
Date: Fri Sep 18 10:32:15 2020 +0200
Bug 20168: Compiled CSS - RTL files
Signed-off-by: Jonathan Druart <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
C4/HoldsQueue.pm | 11 ++-
C4/Reserves.pm | 6 +-
Koha.pm | 2 +-
Koha/Item.pm | 15 ++--
Koha/Schema/Result/Category.pm | 18 ++--
Koha/Schema/Result/HoldFillTarget.pm | 11 ++-
Koha/SearchEngine/Elasticsearch.pm | 51 ++++++++---
Koha/SearchEngine/Elasticsearch/Indexer.pm | 3 +
acqui/neworderempty.pl | 14 ++-
admin/searchengine/elasticsearch/field_config.yaml | 2 +
cataloguing/value_builder/marc21_field_260b.pl | 59 +++++++++++++
circ/returns.pl | 12 +--
debian/scripts/koha-elasticsearch | 2 +-
installer/data/mysql/kohastructure.sql | 1 +
installer/data/mysql/updatedatabase.pl | 20 ++++-
koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 4 +
.../prog/en/includes/blocking_errors.inc | 2 +
.../prog/en/includes/borrower_debarments.inc | 2 +-
.../prog/en/includes/budgets-active-currency.inc | 2 +-
.../prog/en/includes/cateditor-ui.inc | 2 +-
.../prog/en/includes/checkouts-table.inc | 2 +-
.../intranet-tmpl/prog/en/includes/holds_table.inc | 12 +--
.../prog/en/includes/patron-article-requests.inc | 2 +-
.../intranet-tmpl/prog/en/includes/permissions.inc | 2 +-
.../prog/en/includes/waiting_holds.inc | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 64 +++++++-------
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 8 +-
.../prog/en/modules/acqui/invoice-files.tt | 2 +-
.../prog/en/modules/acqui/lateorders.tt | 8 +-
.../prog/en/modules/acqui/neworderempty.tt | 4 +-
.../prog/en/modules/acqui/newordersuggestion.tt | 10 +--
.../prog/en/modules/acqui/orderreceive.tt | 2 +-
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 18 ++--
.../prog/en/modules/admin/aqbudgetperiods.tt | 2 +-
.../prog/en/modules/admin/aqcontract.tt | 2 +-
.../intranet-tmpl/prog/en/modules/admin/aqplan.tt | 4 +-
.../en/modules/admin/auth_subfields_structure.tt | 4 +-
.../prog/en/modules/admin/auth_tag_structure.tt | 2 +-
.../prog/en/modules/admin/categories.tt | 4 +-
.../prog/en/modules/admin/checkmarc.tt | 2 +-
.../prog/en/modules/admin/itemtypes.tt | 6 +-
.../en/modules/admin/marc_subfields_structure.tt | 4 +-
.../en/modules/admin/preferences/borrowers.json | 4 +-
.../en/modules/admin/preferences/cataloguing.pref | 2 +-
.../en/modules/admin/preferences/circulation.pref | 7 +-
.../en/modules/admin/preferences/searching.pref | 2 +-
.../admin/searchengine/elasticsearch/mappings.tt | 5 ++
.../prog/en/modules/authorities/detail.tt | 2 +-
.../modules/authorities/searchresultlist-auth.tt | 2 +-
.../intranet-tmpl/prog/en/modules/basket/basket.tt | 2 +-
.../prog/en/modules/catalogue/MARCdetail.tt | 6 +-
.../prog/en/modules/catalogue/detail.tt | 6 +-
.../prog/en/modules/catalogue/imageviewer.tt | 4 +-
.../prog/en/modules/catalogue/issuehistory.tt | 4 +-
.../prog/en/modules/catalogue/labeledMARCdetail.tt | 6 +-
.../prog/en/modules/catalogue/moredetail.tt | 2 +-
.../prog/en/modules/catalogue/stockrotation.tt | 2 +-
.../prog/en/modules/cataloguing/addbooks.tt | 4 +-
.../prog/en/modules/cataloguing/linkitem.tt | 4 +-
.../prog/en/modules/cataloguing/moveitem.tt | 6 +-
.../value_builder/unimarc_field_210c.tt | 2 +-
.../prog/en/modules/circ/branchoverdues.tt | 2 +-
.../prog/en/modules/circ/branchtransfers.tt | 8 +-
.../prog/en/modules/circ/circulation.tt | 18 ++--
.../prog/en/modules/circ/pendingreserves.tt | 8 +-
.../prog/en/modules/circ/reserveratios.tt | 6 +-
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 4 +-
.../prog/en/modules/circ/transferstoreceive.tt | 2 +-
.../prog/en/modules/clubs/club-enrollments.tt | 2 +-
.../prog/en/modules/clubs/clubs-add-modify.tt | 8 +-
.../intranet-tmpl/prog/en/modules/clubs/clubs.tt | 8 +-
.../prog/en/modules/clubs/patron-enroll.tt | 2 +-
.../prog/en/modules/clubs/templates-add-modify.tt | 4 +-
.../en/modules/course_reserves/add_items-step1.tt | 2 +-
.../en/modules/course_reserves/add_items-step2.tt | 6 +-
.../en/modules/course_reserves/batch_add_items.tt | 4 +-
.../en/modules/course_reserves/course-details.tt | 12 +--
.../prog/en/modules/course_reserves/course.tt | 2 +-
.../prog/en/modules/ill/log/status_change.tt | 2 +-
.../intranet-tmpl/prog/en/modules/labels/result.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 2 +-
.../prog/en/modules/members/moremember.tt | 6 +-
.../prog/en/modules/members/paycollect.tt | 6 +-
.../prog/en/modules/onboarding/onboardingstep1.tt | 2 +-
.../prog/en/modules/onboarding/onboardingstep2.tt | 4 +-
.../prog/en/modules/onboarding/onboardingstep3.tt | 2 +-
.../prog/en/modules/plugins/plugins-home.tt | 2 +-
.../prog/en/modules/plugins/plugins-upload.tt | 14 +--
koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 2 +-
.../prog/en/modules/reports/acquisitions_stats.tt | 2 +-
.../en/modules/reports/guided_reports_start.tt | 6 +-
.../prog/en/modules/reserve/request.tt | 4 +-
.../prog/en/modules/reviews/reviewswaiting.tt | 2 +-
.../en/modules/rotating_collections/addItems.tt | 12 +--
.../rotating_collections/editCollections.tt | 12 +--
.../rotating_collections/transferCollection.tt | 4 +-
.../prog/en/modules/serials/checkexpiration.tt | 6 +-
.../prog/en/modules/serials/result.tt | 2 +-
.../en/modules/serials/routing-preview-slip.tt | 6 +-
.../prog/en/modules/serials/routing-preview.tt | 4 +-
.../prog/en/modules/serials/routing.tt | 6 +-
.../prog/en/modules/serials/serials-collection.tt | 4 +-
.../prog/en/modules/serials/serials-edit.tt | 4 +-
.../prog/en/modules/serials/subscription-add.tt | 4 +-
.../prog/en/modules/serials/subscription-detail.tt | 8 +-
.../prog/en/modules/serials/viewalerts.tt | 4 +-
.../prog/en/modules/suggestion/suggestion.tt | 6 +-
.../intranet-tmpl/prog/en/modules/tags/list.tt | 6 +-
.../intranet-tmpl/prog/en/modules/tools/export.tt | 6 +-
.../prog/en/modules/tools/holidays.tt | 4 +-
.../prog/en/modules/tools/import_borrowers.tt | 8 +-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +-
.../prog/en/modules/tools/manage-marc-import.tt | 4 +-
.../modules/tools/marc_modification_templates.tt | 4 +-
.../prog/en/modules/tools/picture-upload.tt | 36 ++++----
.../prog/en/modules/tools/problem-reports.tt | 2 +-
.../intranet-tmpl/prog/en/modules/tools/quotes.tt | 2 +-
.../prog/en/modules/tools/upload-images.tt | 12 +--
.../prog/en/modules/virtualshelves/shelves.tt | 6 +-
.../prog/en/xslt/UNIMARCslim2intranetDetail.xsl | 99 ++++++++++++----------
.../prog/en/xslt/UNIMARCslimUtils.xsl | 80 ++++++++++-------
koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css | 1 +
koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css | 1 +
koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css | 1 +
.../bootstrap/en/includes/shelfbrowser.inc | 2 +-
.../bootstrap/en/modules/opac-course-details.tt | 2 +-
.../bootstrap/en/modules/opac-course-reserves.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 +-
.../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +-
.../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 12 +--
.../bootstrap/en/xslt/UNIMARCslimUtils.xsl | 6 +-
koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 3 +-
members/paycollect.pl | 20 ++---
misc/cronjobs/overdue_notices.pl | 4 +-
.../maintenance/search_for_data_inconsistencies.pl | 7 +-
misc/migration_tools/bulkmarcimport.pl | 2 +-
opac/opac-main.pl | 4 +-
opac/sco/sco-main.pl | 26 +++---
t/db_dependent/HoldsQueue.t | 12 ++-
.../Koha/Plugins/Biblio_and_Items_plugin_hooks.t | 4 +-
t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 73 +++++++++++++++-
t/db_dependent/Reserves.t | 82 +++++++++++++++++-
t/lib/Koha/Plugin/Test.pm | 6 +-
143 files changed, 801 insertions(+), 461 deletions(-)
create mode 100644 cataloguing/value_builder/marc21_field_260b.pl
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css
hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
