Hi, On Fri, May 3, 2013 at 9:43 AM, Mason James <[email protected]> wrote: > when signing off patches, could we agree to make it compulsory for people to > add a quick comment > to either the bug ticket, (or to the patch itself)? > > it just needs to be a few words, like 'works great!', or 'tested ok', etc... > > what do people think?
The act of signing off should _already_ have the meaning and expectation that the person signing off on it has tested it. If somebody has signed off on a patch, there isn't necessarily anything more to communicate that the Bugzilla status change and Signed-off-by line in the patch don't already signal. Why make an additional comment compulsory? What specific problem would this solve? Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: [email protected] direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
