I've read and re-read your reply, and I'm still not able to comprehend it ; )
Do you think you could break this down more clearly, I guess I'm a bit slow today. http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org ) Mill Run Technology Solutions ( http://millruntech.com ) On Tue, May 7, 2013 at 11:03 AM, Colin Campbell < [email protected]> wrote: > On Tue, May 07, 2013 at 10:21:30AM -0400, Kyle Hall wrote: > > I think we need very > > standard variable names. For example, any and all pages about a single > > patron should have a standard patron variable ( let's say "Borrower" ). > The > > same thing should go for records. > > A lot of the code creates variables for every element. When you have to > invent that many variables the code soon gets inconsistent and buggy. If > we are passing a borrower pass a borrower as a hashref dont disassemble > and reassemble into his constituent part. And there's a lot of code that > manipulates data for presentation reasons before passing it to the > template that can do the same presentation task as well, if not better > (and usually more efficiently). I'd treat any code that retrieves data > and then loops through it as suspect. Safer to get the result set and > pass it to the template to display. Which brings the code closer to the > approach that an ORM would require. > > Colin > > -- > Colin Campbell > Chief Software Engineer, > PTFS Europe Limited > Content Management and Library Solutions > +44 (0) 800 756 6803 (phone) > +44 (0) 7759 633626 (mobile) > [email protected] > skype: colin_campbell2 > > http://www.ptfs-europe.com > _______________________________________________ > Koha-devel mailing list > [email protected] > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ >
_______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
