Hi MJ - Thanks for helping me with this stuff.
On Fri, Jun 20, 2008 at 12:16 PM, MJ Ray <[EMAIL PROTECTED]> wrote: > Andrew Moore <[EMAIL PROTECTED]> wrote: >> SMS::Send is used by the new enhanced messaging stuff. It's a pure-perl >> module that >> provides a consistent interface to SMS sending gateways. There are alredy >> a handful of driver modules for gateways on CPAN, and adding one for a new >> gateway >> is possible. > > Why should SMS::Send be a prerequisite? Shouldn't it be optional? I guess it should be optional. Good point. If it's an optional dependency, how should I indicate that? Should I leave it out of Makefile.PL altogether? > Why does this patch covertly reindent everything? I didn't intend for it to be covert. I was just trying to make each of the statements adhere to some kind of consistent indentation standard. I'd really like to be able to use perltidy to make the code that I edit and contribute more readable. Is there a particular indentation style that you think would be good to use on code that I change in Koha? I couldn't find much about this on the wiki. > Are there any other > changes? Not that I'm aware of. > Why are new features still going in? I'm snowed by all these > additions which mean that I'm spending all day upgrading and retesting > and very little time fixing things :-( I'm not really sure about this part. Thanks! -Andy _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
