On Thu, Jun 26, 2008 at 3:56 PM, Marc Chantreux <[EMAIL PROTECTED]> wrote: > hello Joe, > > On Thu, Jun 26, 2008 at 12:31:22PM -0400, Joe Atzberger wrote: >> Marc -- >> >> Are you sure about this? > > Yes. But this patch is right only if my other patch (add > C4::Context::session) is already applied. > >> And that doesn't look like a proper call to the CGI::Session constructor, >> compared to the others where we specify the driver and file/filehandle. > > my previous patch delegate the choice of driver,id,serializer and driver > configuration to C4::Context::session because: > > - i think that a centralized function to choose them is better than an > string hardcoded twice on 2 differents files ( C4::Auth and > installer/Auth.pm). > - a centralized function can do additional stuff like loading required > modules. > - C4::Context::session use environment variables > KOHA_SESSION_SERIALIZER, KOHA_SESSION_ID, KOHA_SESSION_DRIVER > so the administrator can set them without hacking the code. I wrote this > patch to resolve the problem with the missing yaml freeze in debian > package but it can help for other cases. > - i understood (perhaps incorrectly) that C4::Context is here to deal > with all required but not trival stuff ... so having good session > parameters seems to be a good place there. > > it was just a proposal. If you don't accept it, we have to find another > solution to resolve > http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2216 > that is, according to me, a bug we *have to fix* before the release. > > Actually, if you don't want to apply the previous patch, this one is > just useless. Based on the bug report for 2216, it sounds like it's nothing more than a dependency problem ... is it a legitimate bug in Koha? Does your patch get around the dependency somehow? Sorry to be a bit dense, but I'm not following :-)
Cheers, -- Joshua Ferraro SUPPORT FOR OPEN-SOURCE SOFTWARE CEO migration, training, maintenance, support LibLime Featuring Koha Open-Source ILS [EMAIL PROTECTED] |Full Demos at http://liblime.com/koha |1(888)KohaILS _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
