Going to negative notforloan values will have widespread consequences in
very many scripts and templates. All of them would need to update
conditionals from:
if ($item->{notforloan}) {....}
to:
if ($item->{notforloan} != 0) {....}
The templates would be unable to check:
<!-- TMPL_IF NAME="notforloan" -->
at all. Obviously, based on our experience, EXPR would be of no help.
We would need to build values for the templates that would look like this:
if ($item->{notforloan} < 0) {
$template->param(notforhold=>1);
$template->param(notforloan=>0);
# or even $item->{notforloan}=0;
}
So basically, we'd be trying to get back to notforloan being zero and
pretending we had a separate notforhold column, in which case, it seems like
we should just add the notforhold column and be done with it.
--joe
On Thu, Jul 10, 2008 at 4:38 PM, Ryan Higgins <[EMAIL PROTECTED]> wrote:
> ---
> C4/Reserves.pm | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/C4/Reserves.pm b/C4/Reserves.pm
> index cc20485..353b51b 100644
> --- a/C4/Reserves.pm
> +++ b/C4/Reserves.pm
> @@ -1091,7 +1091,7 @@ item-level hold request. An item is available if
> * it is not lost AND
> * it is not damaged AND
> * it is not withdrawn AND
> -* it is not marked as not for loan
> +* does not have a not for loan value > 0
>
> Whether or not the item is currently on loan is
> also checked - if the AllowOnShelfHolds system preference
> @@ -1140,7 +1140,7 @@ sub IsAvailableForItemLevelRequest {
>
> my $available_per_item = 1;
> $available_per_item = 0 if $item->{itemlost} or
> - $item->{notforloan} or
> + ( $item->{notforloan} > 0 ) or
> ($item->{damaged} and not
> C4::Context->preference('AllowHoldsOnDamagedItems')) or
> $item->{wthdrawn} or
> $notforloan_per_itemtype;
> --
> 1.5.5.GIT
>
> _______________________________________________
> Koha-patches mailing list
> [email protected]
> http://lists.koha.org/mailman/listinfo/koha-patches
>
_______________________________________________
Koha-patches mailing list
[email protected]
http://lists.koha.org/mailman/listinfo/koha-patches
