On 2There is no limit on the SearchMember query, and expansions of scope >>> on a common operation like this will have predictable detrimental >>> effects on performance. While most SearchMember's problems predate >>> this patch, I think this is a step in the wrong direction. >> Note that we also have the problem with surname search : on a large >> library, entering "A" will return all patrons with surname >> starting by >> 'A' or firstname starting by 'A'. >> >> So, maybe we should have a 2 step check : >> - do the search without % >> - if no answer : count the number of results with %. If less than, >> say >> 100 => return, if more => ?? > I believe that running COUNT() will take just as long as running > the query > itself, at least that's my understanding of how COUNT() works.
Some good points raised here, especially Joe's point re: performance So, its good for Koha to attempt to return some results - if no results are returned... But there needs to be a LIMIT (10 or 100?) on those results, so staff dont accidentlly cause runaway SQL queries. So, I'll try to come up with a patch that handles these issues, and re-send. Mason. _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
