Joshua Ferraro a écrit : > On Fri, Aug 1, 2008 at 2:47 AM, paul POULAIN <[EMAIL PROTECTED]> wrote: > >> Joshua Ferraro a écrit : >> >>> Hi Paul, >>> >>> This bug is marked FIXED, can you clarify what remaining issues there >>> are and how your patch addresses them >>> >>> >> it's all in my commit comment (although it doesn't appear on the ML :( ) : >> >> If you have invalid data in your serialitems table, the constraint >> can't be set. >> this patch delete any invalid data before adding the constraint. >> No need to add a 104 : if you had no error in your datas, previous >> 102 worked fine. >> > OK, but what about loss of data, does this solution delete data that > could/should > be repaired instead of deleted? > I can't : the lines I had contained serialid=0 which does not exist. It's orphan datas. Theres should be none. Maybe it's something that remains from a bugguy git. Thus, the delete won't delete anything. But on my 2 tests/dev DB, I had the problem, so I think it's important. And as it's orphan data, it can't be repaired.
-- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc NOUVEAU TELEPHONE : 04 91 81 35 08 _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
