Hi John, On Wed, Aug 13, 2008 at 3:03 PM, John Houser <[EMAIL PROTECTED]> wrote: > For some reason I'm not able to send to koha.org directly from my > server. But here's the script we discussed, and a patch for it.
Thanks for the submission, and as it appears to be your first patch, welcome! This is a useful script, and nearly ready for me to accept as the first cut. There are a couple changes I'd like you to make, though. Please go ahead and turn on warnings. I also suggest naming the script something like add_example_items_to_MARC.pl or add_sample_items_to_MARC.pl, as "add_items_to_MARC.pl" makes it sound like it could be a generic tool that adds real item tags to a MARC file. I see a number of directions for future enhancement (I'm not saying that you have to do any of this, of course): * Have it check the MARC frameworks for the appropriate item tags and subfields, instead of hardcoding the 952. That way, it could be used by UNIMARC users. * Add options for varying some of the values for fields such as the price. * If a Koha database is available, query it for locations and item types - that way, the user is not tied to the English sample data. Thanks again. Regards, Galen -- Galen Charlton VP, Research & Development, LibLime [EMAIL PROTECTED] p: 1-888-564-2457 x709 skype: gmcharlt _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
