Marc --

This doesn't quite make sense, since there is already a "require Exporter;"
line in the BEGIN block.  Certainly we don't need both require and use.

What reason is there to prefer "use Exporter" here?  As far as Bookseller
goes, the @ISA relationship gives us all the functions from Exporter that we
would want.  Is there something I am missing in perl 5.10?

--Joe

On Thu, Oct 9, 2008 at 3:32 AM, Marc Chantreux
<[EMAIL PROTECTED]>wrote:

> ---
>  C4/Bookseller.pm |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm
> index e19378e..01c8a4e 100644
> --- a/C4/Bookseller.pm
> +++ b/C4/Bookseller.pm
> @@ -18,6 +18,7 @@ package C4::Bookseller;
>  # Suite 330, Boston, MA  02111-1307 USA
>
>  use strict;
> +use Exporter;
>
>  use vars qw($VERSION @ISA @EXPORT);
>
> --
> 1.5.4.3
>
> _______________________________________________
> Koha-patches mailing list
> [email protected]
> http://lists.koha.org/mailman/listinfo/koha-patches
>
_______________________________________________
Koha-patches mailing list
[email protected]
http://lists.koha.org/mailman/listinfo/koha-patches

Reply via email to