Hi,
This patch does more than what its description claims. In this case,
the calls to $sth->finish() *are* technically legitimate, since a
search on userid or firstname can produce more than one row in the
result set. Please resubmit, either backing out of the $sth->finish
change or (as the DBI documentation suggests), replace the use of
finish() by with selectrow_*.
Regards,
Galen
On Thu, Oct 30, 2008 at 12:10 AM, Joe Atzberger
<[EMAIL PROTECTED]> wrote:
> ---
> C4/Members.pm | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/C4/Members.pm b/C4/Members.pm
> index e756ffb..7ee9eb3 100644
> --- a/C4/Members.pm
> +++ b/C4/Members.pm
> @@ -527,7 +527,7 @@ SELECT borrowers.*, categories.category_type,
> categories.description
> FROM borrowers
> LEFT JOIN categories on borrowers.categorycode=categories.categorycode
> ";
> - if ( defined $type && ( $type eq 'cardnumber' || $type eq 'firstname'||
> $type eq 'userid'|| $type eq 'borrowernumber' ) ){
> + if (defined($type) and ( $type eq 'cardnumber' || $type eq 'firstname'||
> $type eq 'userid'|| $type eq 'borrowernumber' ) ){
> $information = uc $information;
> $sth = $dbh->prepare("$select WHERE $type=?");
> } else {
> @@ -535,14 +535,12 @@ LEFT JOIN categories on
> borrowers.categorycode=categories.categorycode
> }
> $sth->execute($information);
> my $data = $sth->fetchrow_hashref;
> - $sth->finish;
> ($data) and return ($data);
>
> - if ($type eq 'cardnumber' || $type eq 'firstname') { # otherwise, try
> with firstname
> + if (defined($type) and ($type eq 'cardnumber' || $type eq 'firstname'))
> { # otherwise, try with firstname
> $sth = $dbh->prepare("$select WHERE firstname like ?");
> $sth->execute($information);
> $data = $sth->fetchrow_hashref;
> - $sth->finish;
> ($data) and return ($data);
> }
> return undef;
> --
> 1.5.5.GIT
>
> _______________________________________________
> Koha-patches mailing list
> [email protected]
> http://lists.koha.org/mailman/listinfo/koha-patches
>
--
Galen Charlton
VP, Research & Development, LibLime
[EMAIL PROTECTED]
p: 1-888-564-2457 x709
skype: gmcharlt
_______________________________________________
Koha-patches mailing list
[email protected]
http://lists.koha.org/mailman/listinfo/koha-patches
