Hi Stephen, On Tue, Mar 3, 2009 at 10:24 AM, Stephen Edwards <[email protected]> wrote: > koha-tmpl/opac-tmpl/prog/en/css/opac.css | 6 +- > koha-tmpl/opac-tmpl/prog/en/js/basket.js | 8 +- > .../opac-tmpl/prog/en/modules/opac-basket.tmpl | 19 +- > .../opac-tmpl/prog/en/modules/opac-reserve.tmpl | 651 > +++++++++++++------- > .../opac-tmpl/prog/en/modules/opac-results.tmpl | 59 ++- > .../opac-tmpl/prog/en/modules/opac-shelves.tmpl | 24 + > opac/opac-reserve.pl | 537 ++++++++++------
Getting closer. I think one last iteration will do the trick. You've addressed my concerns about the behavior of this feature when JavaScript is turned off. The main problem now is that while warnings are now enabled in opac-reserve.pl, some of the problems turned up by the pragma have not been fixed, leading to clutter like this in the Apache error log: [Wed Mar 04 09:02:20 2009] [error] [client 74.179.117.85] [Wed Mar 4 09:02:20 2009] opac-reserve.pl: Use of uninitialized value in string eq at /home/gmc/koha/dev/opac/opac-reserve.pl line 262., referer: http://gmc.dev.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=378 [Wed Mar 04 09:02:20 2009] [error] [client 74.179.117.85] [Wed Mar 4 09:02:20 2009] opac-reserve.pl: Use of uninitialized value in string eq at /home/gmc/koha/dev/opac/opac-reserve.pl line 269., referer: http://gmc.dev.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=378 [Wed Mar 04 09:02:20 2009] [error] [client 74.179.117.85] [Wed Mar 4 09:02:20 2009] opac-reserve.pl: Use of uninitialized value in sprintf at /home/gmc/koha/dev/opac/opac-reserve.pl line 352., referer: http://gmc.dev.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=378 [Wed Mar 04 09:02:20 2009] [error] [client 74.179.117.85] [Wed Mar 4 09:02:20 2009] opac-reserve.pl: Use of uninitialized value in sprintf at /home/gmc/koha/dev/opac/opac-reserve.pl line 352., referer: http://gmc.dev.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=378 [Wed Mar 04 09:02:20 2009] [error] [client 74.179.117.85] [Wed Mar 4 09:02:20 2009] opac-reserve.pl: Use of uninitialized value in concatenation (.) or string at /home/gmc/koha/dev/opac/opac-reserve.pl line 356., referer: http://gmc.dev.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=378 [Wed Mar 04 09:02:20 2009] [error] [client 74.179.117.85] [Wed Mar 4 09:02:20 2009] opac-reserve.pl: Use of uninitialized value in hash element at /home/gmc/koha/dev/opac/opac-reserve.pl line 365., referer: http://gmc.dev.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=378 [Wed Mar 04 09:02:20 2009] [error] [client 74.179.117.85] [Wed Mar 4 09:02:20 2009] opac-reserve.pl: Use of uninitialized value in string ne at /home/gmc/koha/dev/opac/opac-reserve.pl line 436., referer: http://gmc.dev.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=378 > $("#requestany").click(function() { > if(this.checked){ > $("inp...@name=checkitem]").each(function() { > $(this).attr("checked",""); > }); > - } > + }sdf This is a syntax error. However, I notice that requestany is no longer used as a div ID anyway, so I think all of the JavaScript that refers to #requestany can simply be removed. > + # Some JavaScript-specific identifiers > + $biblioLoopIter{checkitem_bib} = "checkitem_" . > $biblioData->{biblionumber}; > + $biblioLoopIter{reqtype_bib} = "reqtype_" . $biblioData->{ This is mingling presentation and business logic a little too closely - div and span IDs ought to be constructed in the template rather than the code if at all possible. Regards, Galen -- Galen Charlton VP, Research & Development, LibLime [email protected] p: 1-888-564-2457 x709 skype: gmcharlt _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
