[Koha-patches] [PATCH] Fix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated as IMGs but show as broken images

Daniel Sweeney Fri, 06 Mar 2009 08:40:57 -0800

From: Joshua Ferraro <[email protected]>

Adds new template variable to test for enhanced content identifiers


Signed-off-by: Daniel Sweeney <[email protected]>
---
 C4/Search.pm                                       |    1 +
 .../opac-tmpl/prog/en/modules/opac-detail.tmpl     |    8 +++-----
 .../opac-tmpl/prog/en/modules/opac-results.tmpl    |    3 +--
 opac/opac-ISBDdetail.pl                            |    3 ++-
 opac/opac-detail.pl                                |    3 ++-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/C4/Search.pm b/C4/Search.pm
index 5a3a3a6..56575ee 100644
--- a/C4/Search.pm
+++ b/C4/Search.pm
@@ -1279,6 +1279,7 @@ sub searchResults {
                $oldbiblio->{normalized_ean} = 
GetNormalizedEAN($marcrecord,$marcflavour);
                $oldbiblio->{normalized_oclc} = 
GetNormalizedOCLCNumber($marcrecord,$marcflavour);
                $oldbiblio->{normalized_isbn} = 
GetNormalizedISBN(undef,$marcrecord,$marcflavour);
+               $oldbiblio->{content_identifier_exists} = 1 if 
($oldbiblio->{normalized_isbn} or $oldbiblio->{normalized_oclc} or 
$oldbiblio->{normalized_ean});
                $oldbiblio->{description} = $itemtypes{ $oldbiblio->{itemtype} 
}->{description};
  # Build summary if there is one (the summary is defined in the itemtypes 
table)
  # FIXME: is this used anywhere, I think it can be commented out? -- JF
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl 
b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
index cb5e09a..429ef5e 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
@@ -337,10 +337,8 @@
         <td rowspan="2" style="width:20px;"><a style="height: 10em;" 
href="/cgi-bin/koha/opac-detail.pl?biblionumber=<!-- TMPL_IF 
NAME="shelfbrowser_prev_biblionumber" --><!-- TMPL_VAR 
NAME="shelfbrowser_prev_biblionumber" --><!-- TMPL_ELSE --><!-- TMPL_VAR 
NAME="biblionumber" --><!-- /TMPL_IF -->&amp;shelfbrowse_itemnumber=<!-- 
TMPL_VAR NAME="shelfbrowser_prev_itemnumber" -->#shelfbrowser"><img 
src="/opac-tmpl/prog/images/browse-prev.gif" alt="Previous" border="0" 
/></a></td>
 <!-- TMPL_LOOP NAME="PREVIOUS_SHELF_BROWSE" -->
         <td><a href="/cgi-bin/koha/opac-detail.pl?biblionumber=<!-- TMPL_VAR 
NAME="biblionumber" -->&amp;shelfbrowse_itemnumber=<!-- TMPL_VAR 
NAME="itemnumber" -->#shelfbrowser">
-
-    <!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF 
NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="browser_normalized_isbn" -->
-    <img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR 
NAME="browser_normalized_isbn"-->.01._AA75_PU_PU-5_.jpg" alt="" /><!-- 
TMPL_ELSE --><span class="no-image">No cover image available</span><!-- 
/TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF -->
-       <!-- TMPL_IF NAME="SyndeticsEnabled" --><!-- TMPL_IF 
NAME="SyndeticsCoverImages" --><img border="0" 
src="http://syndetics.com/index.aspx?isbn=<!-- TMPL_VAR 
NAME="browser_normalized_isbn" -->/SC.GIF&amp;client=<!-- TMPL_VAR 
NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="browser_normalized_upc" 
-->&amp;upc=<!-- TMPL_VAR NAME="browser_normalized_upc" --><!-- /TMPL_IF 
--><!-- TMPL_IF NAME="browser_normalized_oclc" -->&amp;oclc=<!-- TMPL_VAR 
NAME="browser_normalized_oclc" --><!-- /TMPL_IF -->&amp;type=xw10" alt="" 
/><!-- /TMPL_IF --><!-- /TMPL_IF -->
+    <!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF 
NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="browser_normalized_isbn" 
--><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR 
NAME="browser_normalized_isbn"-->.01._AA75_PU_PU-5_.jpg" alt="" /><!-- 
TMPL_ELSE --><span class="no-image">No cover image available</span><!-- 
/TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF -->
+       <!-- TMPL_IF NAME="SyndeticsEnabled" --><!-- TMPL_IF 
NAME="SyndeticsCoverImages" --><!-- TMPL_IF NAME="content_identifier_exists" 
--><img border="0" src="http://syndetics.com/index.aspx?isbn=<!-- TMPL_VAR 
NAME="browser_normalized_isbn" -->/SC.GIF&amp;client=<!-- TMPL_VAR 
NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="browser_normalized_upc" 
-->&amp;upc=<!-- TMPL_VAR NAME="browser_normalized_upc" --><!-- /TMPL_IF 
--><!-- TMPL_IF NAME="browser_normalized_oclc" -->&amp;oclc=<!-- TMPL_VAR 
NAME="browser_normalized_oclc" --><!-- /TMPL_IF -->&amp;type=xw10" alt="" 
/><!-- TMPL_ELSE --><span class="no-image">No cover image available</span><!-- 
/TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF -->
     <!-- TMPL_IF NAME="GoogleJackets" --><!-- TMPL_IF 
NAME="browser_normalized_isbn" --><div style="block" title="<!-- TMPL_VAR 
NAME="biblionumber" ESCAPE="URL" -->" class="<!-- TMPL_VAR 
name="browser_normalized_isbn" -->" id="gbs-thumbnail<!--TMPL_VAR 
NAME="__counter__"-->"></div><!-- TMPL_ELSE --><span class="no-image">No cover 
image available</span><!-- /TMPL_IF --><!-- /TMPL_IF -->
     <!-- TMPL_IF NAME="BakerTaylorEnabled" --><!-- TMPL_IF 
NAME="browser_normalized_isbn" -->
     <img alt="See Baker &amp; Taylor" src="<!-- TMPL_VAR 
NAME="BakerTaylorImageURL" ESCAPE="HTML" --><!-- TMPL_VAR 
NAME="browser_normalized_isbn" -->" /><!-- TMPL_ELSE --><span 
class="no-image">No cover image available</span><!-- /TMPL_IF --><!-- /TMPL_IF 
-->
@@ -353,7 +351,7 @@
 
     <!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF 
NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="browser_normalized_isbn" -->
     <img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR 
NAME="browser_normalized_isbn"-->.01._AA75_PU_PU-5_.jpg" alt="" /><!-- 
TMPL_ELSE --><span class="no-image">No cover image available</span><!-- 
/TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF -->
-       <!-- TMPL_IF NAME="SyndeticsEnabled" --><!-- TMPL_IF 
NAME="SyndeticsCoverImages" --><img border="0" 
src="http://syndetics.com/index.aspx?isbn=<!-- TMPL_VAR 
NAME="browser_normalized_isbn" -->/SC.GIF&amp;client=<!-- TMPL_VAR 
NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="browser_normalized_upc" 
-->&amp;upc=<!-- TMPL_VAR NAME="browser_normalized_upc" --><!-- /TMPL_IF 
--><!-- TMPL_IF NAME="browser_normalized_oclc" -->&amp;oclc=<!-- TMPL_VAR 
NAME="browser_normalized_oclc" --><!-- /TMPL_IF -->&amp;type=xw10" alt="" 
/><!-- /TMPL_IF --><!-- /TMPL_IF -->
+       <!-- TMPL_IF NAME="SyndeticsEnabled" --><!-- TMPL_IF 
NAME="SyndeticsCoverImages" --><!-- TMPL_IF NAME="content_identifier_exists" 
--><img border="0" src="http://syndetics.com/index.aspx?isbn=<!-- TMPL_VAR 
NAME="browser_normalized_isbn" -->/SC.GIF&amp;client=<!-- TMPL_VAR 
NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="browser_normalized_upc" 
-->&amp;upc=<!-- TMPL_VAR NAME="browser_normalized_upc" --><!-- /TMPL_IF 
--><!-- TMPL_IF NAME="browser_normalized_oclc" -->&amp;oclc=<!-- TMPL_VAR 
NAME="browser_normalized_oclc" --><!-- /TMPL_IF -->&amp;type=xw10" alt="" 
/><!-- TMPL_ELSE --><span class="no-image">No cover image available</span><!-- 
/TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF -->
     <!-- TMPL_IF NAME="GoogleJackets" --><!-- TMPL_IF 
NAME="browser_normalized_isbn" --><div style="block" title="<!-- TMPL_VAR 
NAME="biblionumber" ESCAPE="URL" -->" class="<!-- TMPL_VAR 
name="browser_normalized_isbn" -->" id="gbs-thumbnail<!--TMPL_VAR 
NAME="__counter__"-->"></div><!-- TMPL_ELSE --><span class="no-image">No cover 
image available</span><!-- /TMPL_IF --><!-- /TMPL_IF -->
     <!-- TMPL_IF NAME="BakerTaylorEnabled" --><!-- TMPL_IF 
NAME="browser_normalized_isbn" -->
     <img alt="See Baker &amp; Taylor" src="<!-- TMPL_VAR 
NAME="BakerTaylorImageURL" ESCAPE="HTML" --><!-- TMPL_VAR 
NAME="browser_normalized_isbn" -->" /><!-- TMPL_ELSE --><span 
class="no-image">No cover image available</span><!-- /TMPL_IF --><!-- /TMPL_IF 
-->
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl 
b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
index 6853d0d..fa364be 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
@@ -298,8 +298,7 @@ $(document).ready(function(){
                                        <a class="p1" 
href="/cgi-bin/koha/opac-detail.pl?biblionumber=<!-- TMPL_VAR 
NAME="biblionumber" -->">
                     <!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF 
NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="normalized_isbn" --><img 
src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" 
-->.01.TZZZZZZZ.jpg" alt="" class="thumbnail" /><!-- TMPL_ELSE --><span 
class="no-image">No cover image available</span><!-- /TMPL_IF --><!-- /TMPL_IF 
--><!-- /TMPL_IF -->
 
-                                       <!-- TMPL_IF NAME="SyndeticsEnabled" 
--><!-- TMPL_IF NAME="SyndeticsCoverImages" --><img 
src="http://syndetics.com/index.aspx?isbn=<!-- TMPL_VAR NAME="normalized_isbn" 
-->/SC.GIF&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" -->&type=xw10<!-- 
TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" 
--><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR 
NAME="normalized_oclc" --><!-- /TMPL_IF -->" alt="" class="thumbnail" /><!-- 
TMPL_ELSE --><span class="no-image">No cover image available</span><!-- 
/TMPL_IF --><!-- /TMPL_IF -->
-
+                                       <!-- TMPL_IF NAME="SyndeticsEnabled" 
--><!-- TMPL_IF NAME="SyndeticsCoverImages" --><!-- TMPL_IF 
NAME="content_identifier_exists" --><img 
src="http://syndetics.com/index.aspx?isbn=<!-- TMPL_VAR NAME="normalized_isbn" 
-->/SC.GIF&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" -->&type=xw10<!-- 
TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" 
--><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR 
NAME="normalized_oclc" --><!-- /TMPL_IF -->" alt="" class="thumbnail" /><!-- 
TMPL_ELSE --><span class="no-image">No cover image available</span><!-- 
/TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF -->
                     <!-- TMPL_IF NAME="GoogleJackets" --><!-- TMPL_IF 
NAME="normalized_isbn" --><div style="block" title="<!-- TMPL_VAR 
NAME="biblionumber" ESCAPE="URL" -->" class="<!-- TMPL_VAR 
name="normalized_isbn" -->" id="gbs-thumbnail<!--TMPL_VAR 
NAME="__counter__"-->"></div><!-- TMPL_ELSE --><span class="no-image">No cover 
image available</span><!-- /TMPL_IF --><!-- /TMPL_IF -->
                     </a>
                     <!-- TMPL_IF NAME="BakerTaylorEnabled" --><!-- TMPL_IF 
NAME="normalized_isbn" --><a href="https://<!-- TMPL_VAR 
name="BakerTaylorBookstoreURL" ESCAPE="HTML" --><!-- TMPL_VAR 
name="normalized_isbn" -->"><img alt="See Baker &amp; Taylor" src="<!-- 
TMPL_VAR name="BakerTaylorImageURL" ESCAPE="HTML" --><!-- TMPL_VAR 
name="normalized_isbn" -->" /></a><!-- TMPL_ELSE --><span class="no-image">No 
cover image available</span><!-- /TMPL_IF --><!-- /TMPL_IF -->
diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl
index 3c5c27f..7b19a99 100755
--- a/opac/opac-ISBDdetail.pl
+++ b/opac/opac-ISBDdetail.pl
@@ -73,12 +73,13 @@ my $upc = GetNormalizedUPC($record,$marcflavour);
 my $ean = GetNormalizedEAN($record,$marcflavour);
 my $oclc = GetNormalizedOCLCNumber($record,$marcflavour);
 my $isbn = GetNormalizedISBN(undef,$record,$marcflavour);
-
+my $content_identifier_exists = 1 if ($isbn or $ean or $oclc);
 $template->param(
     normalized_upc => $upc,
     normalized_ean => $ean,
     normalized_oclc => $oclc,
     normalized_isbn => $isbn,
+       content_identifier_exists => $content_identifier_exists,
 );
 
 #coping with subscriptions
diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
index b2e2129..a56c1df 100755
--- a/opac/opac-detail.pl
+++ b/opac/opac-detail.pl
@@ -195,12 +195,13 @@ my $upc = GetNormalizedUPC($record,$marcflavour);
 my $ean = GetNormalizedEAN($record,$marcflavour);
 my $oclc = GetNormalizedOCLCNumber($record,$marcflavour);
 my $isbn = GetNormalizedISBN(undef,$record,$marcflavour);
-
+my $content_identifier_exists = 1 if ($isbn or $ean or $oclc);
 $template->param(
        normalized_upc => $upc,
        normalized_ean => $ean,
        normalized_oclc => $oclc,
        normalized_isbn => $isbn,
+       content_identifier_exists =>  $content_identifier_exists,
 );
 
 # COinS format FIXME: for books Only
-- 
1.5.6.5

_______________________________________________
Koha-patches mailing list
[email protected]
http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] Fix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated as IMGs but show as broken images

Reply via email to