On Sun, Mar 8, 2009 at 7:31 AM, Mason James <[email protected]>wrote:
> err, the 'warn sprintf()'s still actually output to STDOUT :/ > this patch fixes that. > Um, no they don't. "$debug and printf ..." would go to STDOUT, but warns would still go to STDERR. To demonstrate: perl -e 'warn sprintf "foo"' >/dev/null The lines you changed to warns probably should also have the trailing "\n" removed since warn takes care of that itself. I think I agree with the intention of the patch, but the description and execution have issues. --joe
_______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
