On 2009/03/10, at 3:28 AM, Galen Charlton wrote: > Hi, > > On Sun, Mar 8, 2009 at 6:58 AM, Mason James > <[email protected]> wrote: >> sub ldapserver_error ($) { >> - return sprintf('No ldapserver "%s" defined in KOHA_CONF: >> ' . $ENV{KOHA_CONF}, shift); >> + return warn sprintf('No ldapserver "%s" defined in >> KOHA_CONF: ' . $ENV{KOHA_CONF}, shift); >> } > > Changing "return sprintf" to "return warn sprintf" means that you're > changing the return value from the error message to the value 1. The > die statements that use ldapserver_error() would thus provide *less* > information.
yep, i too spotted this error and fixed on my next patch > I agree with the intention of making sure that debug messages get sent > to STDERR instead of STDOUT, but this patch and its successor need > work. no problemo, new patch sent... this one looks better thanks again for the clues Joe and Galen _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
