Galen, thanks, will send a new patch with changes you have suggested. There is another problem I need to fix - When the system preference is set to on, the feature should be available in the OPAC, but transliteration should be disabled by default. User can enable it by using 'ctrl+g'.
Thanks, Savitra On Sat, Jun 6, 2009 at 5:05 AM, Galen Charlton <[email protected]>wrote: > Hi Savitra, > > On Thu, Jun 4, 2009 at 6:37 AM, savitra.sirohi > <[email protected]> wrote: > > This is available only on the masthead search box in the OPAC. > > > > User has to enter a word in english and press space or return to > transliterate the word. The destination language can be selected from a drop > down list. User can temporarily turn on/off the feature by using "ctrl +g". > > > > A system preference - GoogleIndicTransliteration can be used to turn on > this feature. > > Thanks. I've pushed this patch along with a followup by me to tweak > the default size of the OPAC search input box. There are some things > you could do to follow and improve this feature: > > [1] The GoogleIndicTransliteration system preference should be added > to the installer and update database scripts. Since the Google > transliteration API supports at least one non-Indic language (Arabic) > and may be extended in the future, a better name for the system > preference would be GoogleTransliteration. > > [2] Along those same lines, it would be good if the list of languages > used by the transliteration system were set in a system preference > instead of being hardcoded in googleindictransliteration.js. > > [3] Finally, since a number of OPAC scripts can display the search > box, rather than setting the GoogleIndicTransliteration template > variable in individual scripts, it would be better to set it for all > OPAC scripts by editing get_template_and_user() in C4/Auth.pm. > > Thanks again for the patch. > > Regards, > > Galen > -- > Galen Charlton > VP, Research & Development, LibLime > [email protected] > p: 1-888-564-2457 x709 > skype: gmcharlt >
_______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
