>> - binmode STDOUT, ':utf8'; >> - > > [1] I have not been able to reproduce the double-encoding problem - a > report on biblio.title looks OK for titles that include diacritics. > Please add more information about how to reproduce the problem to the > bug. > > [2] The two lines that this patch removes were lines that you yourself > added in commit f6027eb4 to ensure correct UTF-8 text in CSV > downloads. Removing these lines would cause a regression for CSV > output, would it not?
Those utf8 issues are very strange. I don't understand the logic. I confirm I had also to suppress this line to avoid corrupted reports. My 'feeling' is that binmode should be avoided at all. If characters are correctly handled in Perl script, explicitly specifying output file encoding is not required anymore. If you began doing binmode on files, you also need to encode-decode strings, and at the end of the day you get Nahuel double-encoding problems. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
