Dear all, To be a bit more precise than the commit message: In s/A/B/gx Only A may contain comments, comments are not allowed in B.
Sébastien.
>From 913cbfa5f57d4a173ccc987162f1622ebab13bc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Hinderer?= <[email protected]> Date: Wed, 4 Nov 2009 08:57:25 +0100 Subject: [PATCH] C4/Biblio.pm: bugfix in GetISBDView Content-Type: text/plain; charset="utf-8" There was a comment in the middle of the substitution of {{subfieldtag}} by its value, and that comment spoiled the substitution. The comment has been removed rather than moved because it does not seem that necessary: compared to the sur-rounding code, this line is rather readable and does probably not diserve a comment. --- C4/Biblio.pm | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index cf48c91..fc5031b 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -727,11 +727,7 @@ sub GetISBDView { $subf[$i][1], '', $tagslib ); my $tagsubf = $tag . $subfieldcode; - $calculated =~ s/ # replace all {{}} codes by the value code. - \{\{$tagsubf\}\} # catch the {{actualcode}} - / - $valuecode # replace by the value code - /gx; + $calculated =~ s/\{\{$tagsubf\}\}/$valuecode/gx; $calculated =~ s/\{(.?.?.?.?)$tagsubf(.*?)\}/$1$subfieldvalue$2\{$1$tagsubf$2\}/g; -- 1.6.5
_______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
