Owen Leonard wrote:
> White space in table cells can often break the javascript tablesorter.
> The previous patch to tie the js tablesorter to the shelf sort
> parameters should work now.
> ---
> .../opac-tmpl/prog/en/modules/opac-shelves.tmpl | 11 +----------
> 1 files changed, 1 insertions(+), 10 deletions(-)
>
>
This patch applies great.
But can I suggest some things ?
a) seems that loop on subtitle is not managed here as it is in opac-results.
should be a separate bug or patch, nahuel could you take that ?
b) seems that we could have :
<!--TMPL_VAR Name="biblioview"--> set to ISBD, MARC or nothing. and then
we would have no use for those copy paste of lines of code in order to
choose the correct link for view?
I am only realizing that. And I think this could be something easy and
fast to do. And would ease the pain of reading and editing those
template files.
> diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl
> b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl
> index 1741d64..87b78fc 100644
> --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl
> +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl
> @@ -245,16 +245,7 @@ $(function() {
> <img src="<!-- TMPL_VAR NAME="imageurl" -->"
> alt="<!-- TMPL_VAR NAME="description" -->" title="<!-- TMPL_VAR
> NAME="description" -->" /><!-- TMPL_VAR NAME="description" -->
> </td>
> <!-- /TMPL_UNLESS -->
> - <td>
> - <!-- TMPL_IF NAME="BiblioDefaultViewmarc" -->
> - <a class="title"
> href="/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=<!-- TMPL_VAR
> NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title"
> escape="html" --> <!-- TMPL_VAR NAME="subtitle" --></a>
> - <!-- TMPL_ELSE -->
> - <!-- TMPL_IF NAME="BiblioDefaultViewisbd" -->
> - <a class="title"
> href="/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=<!-- TMPL_VAR
> NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title"
> escape="html" --> <!-- TMPL_VAR NAME="subtitle" --></a>
> - <!-- TMPL_ELSE -->
> - <a class="title"
> href="/cgi-bin/koha/opac-detail.pl?biblionumber=<!-- TMPL_VAR
> NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title"
> escape="html" --> <!-- TMPL_VAR NAME="subtitle" --></a>
> - <!-- /TMPL_IF -->
> - <!-- /TMPL_IF -->
> + <td><!-- TMPL_IF NAME="BiblioDefaultViewmarc" --><a
> class="title" href="/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=<!--
> TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title"
> escape="html" --> <!-- TMPL_VAR NAME="subtitle" --></a><!-- TMPL_ELSE --><!--
> TMPL_IF NAME="BiblioDefaultViewisbd" --><a class="title"
> href="/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=<!-- TMPL_VAR
> NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title"
> escape="html" --> <!-- TMPL_VAR NAME="subtitle" --></a><!-- TMPL_ELSE --><a
> class="title" href="/cgi-bin/koha/opac-detail.pl?biblionumber=<!-- TMPL_VAR
> NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title"
> escape="html" --> <!-- TMPL_VAR NAME="subtitle" --></a><!-- /TMPL_IF --><!--
> /TMPL_IF -->
> <!-- COinS / OpenURL -->
> <!-- COinS / OpenURL --><span class="Z3988"
> title="<!-- TMPL_VAR NAME="coins" -->"></span>
> <br/>
>
_______________________________________________
Koha-patches mailing list
[email protected]
http://lists.koha.org/mailman/listinfo/koha-patches
