Seems like a cool feature. Just a couple of comments.
On Tue, 2010-01-19 at 15:07 +0000, Kyle M Hall wrote:
[snip]
> diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm
> new file mode 100644
> index 0000000..82a4d5e
> --- /dev/null
> +++ b/C4/RotatingCollections.pm
[snip]
> + getItemnumberByBarcode
There is already a function for this:
C4::Items::GetItemnumberFromBarcode
Please use this function instead. Much easier to maintain one function
than two.
[snip]
> diff --git a/installer/data/mysql/updatedatabase.pl
> b/installer/data/mysql/updatedatabase.pl
> index 4e1d1cf..38fa369 100755
> --- a/installer/data/mysql/updatedatabase.pl
> +++ b/installer/data/mysql/updatedatabase.pl
> @@ -2269,6 +2269,13 @@ if (C4::Context->preference("Version") <
> TransformToNum($DBversion)) {
> SetVersion ($DBversion);
> }
>
> +$DBversion = "3.01.00.014";
> +if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
> + $dbh->do("INSERT INTO `systempreferences` ( `variable` , `value` ,
> `options` , `explanation` , `type` ) VALUES ( 'calcFineOnReturn', '0', '',
> 'Turns on the feature to calculate fines at the time of return and/or renewal
> as an alternative to the nightly cronjob fines system.', 'YesNo' )");
> + print "Upgrade to $DBversion done (add new syspref)\n";
> + SetVersion ($DBversion);
> +}
> +
[snip]
CalcFineOnReturn also seems like a cool feature, but doesn't seem
related to your code in this patch.
Please consider these two points. Thanks.
--
Michael Hafen
Systems Analyst and Programmer
Washington County School District
Utah, USA
for Koha checkout
http://development.washk12.org/gitweb/
or
git://development.washk12.org/koha
_______________________________________________
Koha-patches mailing list
[email protected]
http://lists.koha.org/mailman/listinfo/koha-patches
