Thanks Galen, I'll resubmit the patch this weekend.
Garry On Wed, Apr 7, 2010 at 11:46 AM, Galen Charlton <[email protected]> wrote: > Hi Garry, > > On Sat, Mar 20, 2010 at 10:02 AM, Garry Collum <[email protected]> wrote: >> +...@branch_loop = sort {$a->{branchname} cmp $b->{branchname}} @branch_loop; >> +unshift @branch_loop, {value => "", branchname => "All Locations", }; >> + > > This approach for sorting the branch names is OK, but the handling of > the 'all locations' option is not - it introduces text that the > translation system can't get at. Whenever a default option is needed > for a drop-down list, the default should be specified in the template, > not the code. > > Regards, > > Galen > -- > Galen Charlton > [email protected] > _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
