Hi, On Sun, Jun 2, 2013 at 2:08 PM, Doug Kingston <[email protected]> wrote: > I think there is an error here in _get_text_fields where it calls > $csv->error_input() when there was no error. In the past, it would get an > undef, but the the more recent CSV_XS.pm module, the attribute is not > defined at all and it seg faults. I think error_input() should only be > called if $status != 1. > > Comments? I think this is a Koha bug.
I think it is also a bug in Text::CSV_XS -- at the very least, the module ought to just throw an exception rather than segfault if error_input() is called after a successful parse() -- but I agree that Koha should be checking for parsing errors in the way documented by the module's POD. Would you mind filing a bug at http://bugs.koha-community.org? Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: [email protected] direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha mailing list http://koha-community.org [email protected] http://lists.katipo.co.nz/mailman/listinfo/koha
