Hi all, since Joonas' email the code around the current hold fee functionality has been cleaned up a bit for better readability:
Bug 14702 - Refactor GetReserveFee http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 "The code of GetReserveFee was not very clear. What it did was: check if there are some items not issued. If so and there are no holds, calculate no fee." To me these conditions seemed a bit unusual, I had expected it to - Charge always when placing a hold or - Charge always when a hold is filled It would be interesting to hear what others think of this - does the current behaviour make sense to you? Should it work differently and if yes, how? Katrin Am 27.08.2015 um 13:40 schrieb Joonas Kylmälä: > Hello there, > > Since there has been discussion earlier in this mailing list and in > Bugzilla <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592> > about what should be the behaviour when charging a fee from a hold, I > thought to ask you people here. > > At the moment if you have set a holding fee for X category of accounts > the fee is only charged when there is no items available for loan or > some other patron has placed a hold already in biblio or item level > (correct me if I'm wrong, because I think I am..). > > This makes it impossible to charge a fee when someone makes a hold of > a specific item (which might be because the specific item is not > available in the patrons home branch but is in some other). So in that > scenario no fee will be charged from the patron. I suggest that there > would be some system preference where one could define if one wants to > have the hold charge from an biblio record level or from an item > level. Also I think some other scenarios should be taken in account. > So, please, tell your opinions about this and how do you want it to be > done. > > Note: you can find the setting to enable item level holds here: > <http://10.0.3.132:8080/cgi-bin/koha/admin/smart-rules.pl> > > Best regard, > > Joonas Kylmälä > _______________________________________________ > Koha mailing list http://koha-community.org > [email protected] > https://lists.katipo.co.nz/mailman/listinfo/koha > _______________________________________________ Koha mailing list http://koha-community.org [email protected] https://lists.katipo.co.nz/mailman/listinfo/koha
