Hi Jonathan, You are awesome! Thank you so much for working on this and submitting a patch so quickly! I just tested and your patch worked like a charm. I've updated the filed bug with a sign-off and my notes: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845
In short, I tested various configurations of (a) requiring e-mail verification and (b) requiring or allowing users to select their own passwords during self-registrations, and it worked as expected for all of my tests. The user-supplied password was always used if entered, regardless of e-mail verification settings. And a random password was always generated if users did not select their own password, regardless of e-mail verification settings. Thanks again! Arturo From: Jonathan Druart [mailto:jonathan.dru...@bugs.koha-community.org] Sent: Wednesday, December 20, 2017 09:39 To: Arturo Longoria <arturo.longo...@sll.texas.gov> Cc: Koha <koha@lists.katipo.co.nz> Subject: Re: [Koha] Allowing patrons to set their passwords during self-registration Hi Arturo, I have attached a patch on the bug report you opened. Please test and confirm it fixes your issue. Regards, Jonathan On Tue, 19 Dec 2017 at 18:38 Arturo Longoria <arturo.longo...@sll.texas.gov<mailto:arturo.longo...@sll.texas.gov>> wrote: Hi Liz, Thank you for your tip on how to access the queued e-mail messages! With that information, I was able to view the generated e-mail from this morning and can confirm what I'd suspected -- Koha will ignore the user-supplied password during self-registration if e-mail verification is required. I have filed a bug for this behavior: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845 Arturo -----Original Message----- From: Koha [mailto:koha-boun...@lists.katipo.co.nz<mailto:koha-boun...@lists.katipo.co.nz>] On Behalf Of Liz Rea Sent: Tuesday, December 19, 2017 14:52 To: Koha-Mailinglist <Koha@lists.katipo.co.nz<mailto:Koha@lists.katipo.co.nz>> Subject: Re: [Koha] Allowing patrons to set their passwords during self-registration Hi Arturo, While I haven't tested your scenario precisely, it's possible that the reason that you are having problems here is that we don't want to set a password before the account has been confirmed via email. A possible shortcoming of the feature is that it doesn't take this into account (but haven't tested it so don't take that as absolute truth). Regarding the emails, you can see the registration emails and links by putting this report into your saved sql reports: select to_address, content, time_queued from message_queue where date(time_queued) = CURDATE(); Then copy/paste the link from the content into your browser. The sandboxes don't send mail for a very good reason, to keep spammers from using them for evil. Good luck, happy testing, Liz Catalyst IT ps with apologies to Arturo, I didn't send this to the list and I should have, so sending it again. On 20/12/17 07:12, Arturo Longoria wrote: > No solution yet. I have a suspicion that the problem I'm seeing is because > our library has the PatronSelfRegistrationVerifyByEmail set to "Require" > rather than "Don't require." > > I set up sandbox 6 from BibLibre to test this theory out with master, and if > I set the preference to "Don't require," it will allow me to set my own > password during self-registration without issue after I configure it to > require a password during self-registration. The account is created > successfully and with the password I indicated. > > I then wanted to test it out with "Require," but I'm experiencing an issue > with the sandbox not sending out any e-mails. I've added an e-mail address to > the KohaAdminEmailAddress per the instructions in the wiki, but no luck -- > e-mails are not being sent at all, so I'm not able to test whether it will > allow me to keep the password I entered in the form once I verify my e-mail. > > Other than entering a valid e-mail in KohaAdminEmailAddress, is there > anything else I would need to do in the sandbox to have Koha send e-mails? > I'd like to make sure this is a bug before entering it to Bugzilla. > > Arturo > > -----Original Message----- > From: Koha > [mailto:koha-boun...@lists.katipo.co.nz<mailto:koha-boun...@lists.katipo.co.nz>] > On Behalf Of > Christopher Davis > Sent: Tuesday, December 19, 2017 12:00 > To: Katrin Fischer <katrin.fischer...@web.de<mailto:katrin.fischer...@web.de>> > Cc: Koha <koha@lists.katipo.co.nz<mailto:koha@lists.katipo.co.nz>> > Subject: Re: [Koha] Allowing patrons to set their passwords during > self-registration > > Arturo, > > I would also be interested in the status of this feature. > > Thank you, > > Christopher Davis > Systems & E-Services Librarian > Uintah County Library > cgda...@uintah.utah.gov<mailto:cgda...@uintah.utah.gov> > (435) 789-0091 <14357890091> ext.261 > uintahlibrary.org<http://uintahlibrary.org> > basinlibraries.org<http://basinlibraries.org> > facebook.com/uintahcountylibrary<http://facebook.com/uintahcountylibrary> > instagram.com/uintahcountylibrary<http://instagram.com/uintahcountylibrary> > > > On Mon, Dec 18, 2017 at 3:12 PM, Katrin Fischer > <katrin.fischer...@web.de<mailto:katrin.fischer...@web.de>> > wrote: > >> Hi Arturo, >> >> have you been able to solve this? It should work with the >> configuration you described. If it's still an issue, please consider >> filing a bug report on http://bugs.koha-community.org >> >> Katrin >> >> >> On 29.11.2017 15:18, Arturo Longoria wrote: >> >>> What I do is I remove "password" from the >>> PatronSelfRegistrationBorrowerUnwantedField >>> preference and add "password" to the PatronSelfRegistra >>> >> _______________________________________________ >> Koha mailing list http://koha-community.org >> Koha@lists.katipo.co.nz<mailto:Koha@lists.katipo.co.nz> >> https://lists.katipo.co.nz/mailman/listinfo/koha >> > _______________________________________________ > Koha mailing list http://koha-community.org > Koha@lists.katipo.co.nz<mailto:Koha@lists.katipo.co.nz> > https://lists.katipo.co.nz/mailman/listinfo/koha > _______________________________________________ > Koha mailing list http://koha-community.org > Koha@lists.katipo.co.nz<mailto:Koha@lists.katipo.co.nz> > https://lists.katipo.co.nz/mailman/listinfo/koha -- -- Liz Rea Catalyst.Net Limited Level 6, Catalyst House, 150 Willis Street, Wellington. P.O Box 11053, Manners Street, Wellington 6142 04 803 2265 GPG: B149 A443 6B01 7386 C2C7 F481 B6c2 A49D 3726 38B7 _______________________________________________ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz<mailto:Koha@lists.katipo.co.nz> https://lists.katipo.co.nz/mailman/listinfo/koha _______________________________________________ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz<mailto:Koha@lists.katipo.co.nz> https://lists.katipo.co.nz/mailman/listinfo/koha _______________________________________________ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz https://lists.katipo.co.nz/mailman/listinfo/koha
