On Saturday 18 February 2006 22:49, Bartosz Fabianowski wrote: > Hi list > > I have been tracking the 0.12 branch for a while. Some 6 weeks ago, I > filed bug 119481, reporting that the Kopete email window was broken. > Nobody seems to have had the time to look into this since. With the 0.12 > release coming up, I am slowly growing concerned. I guess most people > like the chat window more, but there definitely are those who prefer for > the window to close after a message has been sent. It would be very > strange to have a release with such a basic feature not working. > > I have looked at the code briefly, but wasn't able to figure out what > was broken. But I had another idea. Technically, the email window is > implemented as a separate class with tons of its own code. But from the > functionality point of view, it seems to me that the only difference > between the email window and the chat window is that the former closes > after a message has been sent and the latter does not. So, I was > thinking, maybe the two could be merged? Maybe Kopete could just ditch > the obsolete email window and add a flag to the chat window class > instead that tells it whether to close or not after a message has been > sent? > > If you don't want to change any strings so close to release, the > distinction between "email window" and "chat window" could be kept in > the preferences and simply toggle the new flag. > > I do realize that the chat window has some extra features that the email > window does not have. Replacing the email window with a souped-up chat > window class would thus add new functionality to it, which is good for > the users. I, for one, really love how the history plugin shows a bit of > context with every message. > > The only thing I am not sure about is the tabbed interface - I have > never used it in my life. I guess the email window does not provide tabs > for multiple conversations. This could also be easily achieved if the > two window classes were to be merged - either by adding another flag > that disables tabs when the email window is chosen or by allowing tabs > but making the tab for the current conversation close when a message is > sent. > > Well, maybe some dev has read this far and has some thoughts on this. I > would be happy to help with coding if there is something I can do with > good C++/Qt skills and minimal knowledge of Kopete's code. > > - Bartosz
I haven't looked to see what needed to be done, but this is on my TODO list to look at before releasing 0.12 final. The problem is that ChatView depends on the fact that it's operating with a KopeteChatWindow object, and so I suppose that going with the flag would be the easiest way to go here. I'll look at it more deeply this weekend and see if I can provide some more direction. Thanks -- Matt _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
