On Saturday 04 March 2006 01:12, Chanika wrote:
> I got the RateInfoTest to pass (it doesn't verify properly yet, only
> checks that it got *something*) but since I've only ever made 2
> commits, I'd like someone to check over this to make sure I didn't do
> anything silly. :) diff is attached.
> basically I had to fix OscarTestBase::loadFile() because it never
> actually opened the file before trying to read from it. :)
>

The changes to OscarTestBase are fine. However, the "delete m_data" in 
RateInfoTask isn't needed since m_data is deleted by OscarTestBase

Nice patch. :)
--
Matt
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to