------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=122827         




------- Additional Comments From kedgedev centrum cz  2006-03-05 02:28 -------
SVN commit 515831 by rjarosz:

Backport fix for bug 122827: crash in ICQ on disconnect due to connect 
elsewhere.
We were emitting signal from already deleted object.
Signal was removed because it wasn't used anyway.

CCBUG: 122827



 M  +0 -2      client.cpp  
 M  +0 -3      closeconnectiontask.cpp  
 M  +0 -5      closeconnectiontask.h  


--- branches/KDE/3.5/kdenetwork/kopete/protocols/oscar/liboscar/client.cpp 
#515830:515831
 @ -341,8 +341,6  @
        //create a new connection and set it up
        Connection* c = createConnection( d->host, QString::number( d->port ) );
        d->closeConnectionTask = new CloseConnectionTask( c->rootTask() );
-//     QObject::connect( d->closeConnectionTask, SIGNAL( disconnected( int, 
const QString& ) ),
-//                       this, SLOT( disconnectionError( int, const QString& ) 
) );
 
        //create the new login task
        m_loginTaskTwo = new StageTwoLoginTask( c->rootTask() );
--- 
branches/KDE/3.5/kdenetwork/kopete/protocols/oscar/liboscar/closeconnectiontask.cpp
 #515830:515831
 @ -90,7 +90,6  @
        
                        Oscar::SNAC s = { 0, 0, 0, 0 };
                        client()->fatalTaskError( s, errorNum );
-                       emit disconnected( errorNum, QString::null );
                        return true; //if there's an error, we'll need to 
disconnect anyways
                }
 
 @ -134,6 +133,4  @
                return false;
 }
 
-#include "closeconnectiontask.moc"
-
 //kate: tab-width 4; indent-mode csands;
--- 
branches/KDE/3.5/kdenetwork/kopete/protocols/oscar/liboscar/closeconnectiontask.h
 #515830:515831
 @ -30,7 +30,6  @
 */
 class CloseConnectionTask : public Task
 {
-Q_OBJECT
 public:
        CloseConnectionTask(Task* parent);
        
 @ -47,10 +46,6  @
 protected:
        virtual bool forMe(const Transfer* transfer) const;
 
-signals:
-       void disconnected( int error, const QString& reason );
-
-       
 private:
        bool parseDisconnectCode( int error, QString& reason );
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to