Hello again,
> -new KAction construction can take a KIcon("iconame"), no need to call
> setIconName
Done
> - kopete/kopeteeditglobalidentitywidget.cpp wasn't commited from your
> QPixmap depcrecation
It is in the repository...
Attached is the new patch.
Sorry, it got larger again, as I went through most of the code and tried to
remove alle the const char* name parameters from the api, after thiago
convinced me that they really should be removed as in Qt4 this isn't done
anymore.
Now setObjectName() is used instead after the allocation of the object.
Because the name parameter hasn't been removed (yet?) from the api in
kparts/componentfactory.h, all the plugin constructors (that will be
instantiated via KParts::createInstanceFrom*) still have the parameter.
There are also some more KAction constructors ported.
Now Kopete::PasswordedAccount::PasswordedAccount() is ambigous, I added the
explicit allowBlankPassword=false. Is this right/Should this be changed?
Also another question:
Sometimes there are things like QString::fromLatin1("_") in the code, but
sometimes just "_" (for example regarding icon names).
I now used QLatin1String("some string") sometimes, but I'm not sure this is
really necessary.
See: http://doc.trolltech.com/4.1/qstring.html#details, section "Conversions
between 8-bit strings and Unicode strings" for more. Are we trying to use
QT_NO_CAST_FROM_ASCII? Otherwise I don't see any point in using
QString::fromLatin1 or QLatin1String on such things as icons and object
names, after all, there are only ascii characters in those sort of strings,
right?
> And if you ever come to aKademy 2006 at Dublin, I really need to offer you
> something for all those efforts :)
Hmm, I don't know if I can come but it would be cool :-)
What do you all think?
Thorben
kopete_huge_noConstCharName_kaction_v1_2.patch.bz2
Description: BZip2 compressed data
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
