Le Mercredi 26 Avril 2006 00:18, Michael Flowers a écrit :
> Hey again,
>
> I have begun to update a couple things in the jabber protocol. Included in
> the patch is updating from deprecated functions and QCA2 support for the
> primary jabberaccount files. Let me know, if the diff that I have provided
> is
> logical,correct,completely wrong,whatever. Once I get feedback
> I'll either apply the requested changes to the other files, or send
> you those diffs.
>
> --Michael Flowers
Remarks:
1. use "svn diff > mypatch.patch" to make the patch
2. Don't comment the code you have changed when submitting the patch.
3. //QMap<QString,JabberTransport*> tranposrts_copy=m_transports;
+ //QMap<QString,JabberTransport*>::Iterator it;
+ //for ( it = tranposrts_copy.begin(); it != tranposrts_copy.end(); ++it
)
+ // delete it.data();
+ m_transports.clear();
is wrong. The "old" idiom is ok. You are dealing with pointers and you need to
free their memory.
4.
+ action = new KAction (i18n ("Join Groupchat..."), 0, "actionJoinChat");
+ action->setIcon(KIcon("jabber_group"));
+ action->connect(this,SIGNAL(triggered(bool)),SLOT(slotJoinNewChat()))
This is wrong, the correct way is
action = new KAction( KIcon("jabber_group"), i18n("Join Groupchat..."),
0, "actionJoinChat");
connect(action, SIGNAL(triggered(bool)), this, SLOT(slotJoinNewChat()));
5. For QCA2 errors, you can check what I've done in libpapillon:
/trunk/KDE/kdenetwork/kopete/protocols/messenger/libpapillon/http/securestream.cpp
--
Michaël Larouche (Shock The Dark Mage)
KDE developer working on Kopete, Kamefu...on dial-up :P
--------------------------------------
Blog: http://mlarouche.blogspot.com/
MSN/Email: [EMAIL PROTECTED]
IRC: irc.freenode.org/DarkShock on #kopete,#solid,#kamefu,#plasma
Jabber: [EMAIL PROTECTED]
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel
