Le Lundi 15 Mai 2006 00:48, Jan Ritzerfeld a écrit : > Hey... > > I'm not quite sure wether this commit won't break some code: > | r540784 | rjarosz | 2006-05-14 17:23:58 +0200 (So, 14 Mai 2006) | 3 lines > | > | Compare more values > > The semantics was changed and the operator== won't do what is still > promised in libkopete/kopeteonlinestatus.h:353: > /** > * Comparison operator > * > * Returns true if both the protocol and the internal status are > * identical. > */ > bool operator==( const OnlineStatus &other ) const;
Then the documentation probably need to be changed.
This was committed in order to fix a bug where the status icon were not
updated in oscar i think.
Note that in MSN, i take care that status with different overlay icons have
different status
>
> Index: libkopete/kopeteonlinestatus.cpp
> ===================================================================
> --- libkopete/kopeteonlinestatus.cpp (Revision 540783)
> +++ libkopete/kopeteonlinestatus.cpp (Arbeitskopie)
> @@ -147,7 +147,14 @@
>
> bool OnlineStatus::operator==( const OnlineStatus &other ) const
> {
> - return d->internalStatus == other.d->internalStatus && d->protocol
> == other.d->protocol; + if ( d->internalStatus ==
> other.d->internalStatus && d->protocol == other.d->protocol && +
> d->weight == other.d->weight && d->overlayIcons == other.d->overlayIcons &&
> + d->description == other.d->description )
> + {
> + return true;
> + }
> +
> + return false;
> }
>
> Gruß
> Jan
> _______________________________________________
> kopete-devel mailing list
> [email protected]
> https://mail.kde.org/mailman/listinfo/kopete-devel
pgpxNcc10MHV9.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
