On Thursday 18 May 2006 13:09, Olivier Goffart wrote: > Le Jeudi 18 Mai 2006 04:49, Rafał Rzepecki a écrit : > > I've been sick of endless notices "incoming encrypted message"/"outgoing > > encrypted message" (and even more about the notices being saved in the > > history), so I've added some configurability and flexibility to the > > cryptography plugin. > > > > The most important change is enabling to use internal messages (notices) > > instead of notices embedded into message, so that "entering encrypted > > mode" gets displayed before first encrypted message and "leaving > > encrypted mode" before any subsequent not encrypted message etc. These > > messages obviously don't clutter the history, but still (hopefully) let > > you see clearly what is encrypted and what isn't. This is now the > > default. The old behaviour is still attainable with new configuration > > options (exposed in the UI). > > > > I'm not familiar with the development cycle of kopete, so please feel > > free to review and possibly merge my changes from > > svn://svn.kde.org/home/kde/branches/work/kopete/cryptography_look > > The branch was copied from > > svn://svn.kde.org/home/kde/branches/kopete/0.12 (I've forgotten to say so > > in the commit message). > > > > If you need any assistance or have any questions, I'm looking forward to > > hear from you. > > Hi. > > Usually, when there is a new contributor, or when we want to review a > patch, we send the pactch dirrectly to the list. (the result of svn diff) > and we don't create branch. > > Once the patch has been approved, it may be commited into the main branch. > > > But never mind, i know how to make a diff between branches :-) > > I haven't tested your patch, but it looks good. > > few notes: > > - NULL is C , in kopete we use 0L for null pointers > - Having a null pointer for KopeteMessage::from is dangerous, even for > internal messages. i would use myself() > - The options to change the color should be disabled if the "append notice" > is not checked > - I fear that if you crypt your message, and not your contact (or the > opposite) the "entering encrypted mode" way will not work fine > > > I don't know if new string still can be included in the 0.12 branch. > (mattr?) > > Related link: http://bugs.kde.org/show_bug.cgi?id=77486 > > I hope you can fix theses issues, your changes looks good.
0.12 is essentially frozen except for bugfixes. this should go into kde4 _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
