Le samedi 5 août 2006 12:20, Roman Jarosz a écrit : > On Sat, 05 Aug 2006 11:47:21 +0200, Olivier Goffart <[EMAIL PROTECTED]> wrote: > > Le samedi 5 août 2006 09:44, Roman Jarosz a écrit : > >> On Sat, 05 Aug 2006 01:02:31 +0200, Olivier Goffart <[EMAIL PROTECTED]> > > > > wrote: > >> > Le samedi 5 août 2006 00:20, Roman Jarosz a écrità: > >> >> Here's the patch to enable storage backend. > >> >> > >> >> Can I commit? > >> > > >> > About this patch: > >> > > >> > * You forgot to remove the code which is now unused (loadXML/saveXML) > >> > :-) > >> > >> I didn't want to remove it just yet. > > > > Why ? > > I didn't want to make big commit but I can remove it it's no problem.
It's not a good idea to leave unused code, especially if it's duplicated. Or we will forget it. > > >> > * retry every minutes if it fail ? Why ? > >> > >> Why? I don't know, it was done this way in old code so I leaved it in > >> new too. > > > > Ok > > I think it's not a good idea. but never mind. > > > > > > Please commit. > > _______________________________________________ > kopete-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kopete-devel
pgpswdlsD6VaT.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
