Le August 26, 2006 18:03, Andre Duffeck a écrit : > Hello, > > I've written a new plugin which allows flexible filtering of messages by > the sender or the content of the messages. > > It can > - Drop messages from contacts not on the contactlist > - Drop messages from contacts on the blacklist > - Drop messages from contacts not on the whitelist > - Drop messages that contain one or more words of a list > - Drop messages that contain all words of a list > > It's not finished yet but most parts already work. I'd like to know what > you think of it and wheter i should import it to svn. > > Also, I'm not sure if the name "Privacy" is the best choice :| > > Regards, > André
Looks like a nice plugin. Privacy is good name IMO. In XMPP, the allow/block list is called the privacy list. Speaking of XMPP, maybe this should be included in core Kopete and integrate with serverside allow/block list. They was some effort in Kopete that never took off, see Kopete::BlackLister in libkopete. But this is just a maybe. First comments (Didn't test the code) - Nice you are using KConfigXT :) - Use radio buttons instead of checkbox. As I read them, the opinions look independant to me and only one can be applied. I can't see why I would want to receive all message and block the message from the black list. This doesn't make sense at all. - Use more explicit variable name than l, w, p. This help for the maintainability in long term and the code is easier to read. This is my personal opinion ;) - You should reuse the metacontact selection dialog (the one from Change Metacontact) to select a contact. Using a text input dialog will be prone to errors. But I guess you used that only for testing :) - Use Protocol:AccountID:ContactID string to store the contact information for the list. Or wait untill we make metacontactId() really unique. -- Michaël Larouche KDE developer working on Kopete, Gamefu(KDE), Solid...on dial-up :P -------------------------------------- Website: http://www.tehbisnatch.org/ MSN/Email: [EMAIL PROTECTED] IRC: irc.freenode.org/DarkShock on #kopete,#solid,#gamefu,#plasma Jabber: [EMAIL PROTECTED] _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
