On Thursday 12 October 2006 08:00, Thiago Macieira wrote: > Rafael Fernández López wrote: > >+ QMap<QTreeWidgetItem *, KPluginInfo *> m_protocolItems; > >+ #define _m_protocolItems d->m_protocolItems > >+ KopeteEditAccountWidget *m_accountPage; > >+ #define _m_accountPage d->m_accountPage > >+ KVBox *m_accountPageWidget; > >+ #define _m_accountPageWidget d->m_accountPageWidget > >+ QWidget *m_selectService; > >+ #define _m_selectService d->m_selectService > >+ QWidget *m_finish; > >+ #define _m_finish d->m_finish > >+ Ui::AddAccountWizardPage1 m_uiSelectService; > >+ #define _m_uiSelectService d->m_uiSelectService > >+ Ui::AddAccountWizardPage2 m_uiFinish; > >+ #define _m_uiFinish d->m_uiFinish > >+ Kopete::Protocol *m_proto; > >+ #define _m_proto d->m_proto > >+ KPageWidgetItem *m_selectServiceItem; > >+ #define _m_selectServiceItem d->m_selectServiceItem > > Those #defines are extremely ugly. Are they common practice in Kopete > code?
no, they're not common practice. Refactor the code to use the d pointer rather than these ugly defines. -- Matt _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
