On Friday 13 October 2006 09:10, Rafael Fernández López wrote: > Ey !! Does not matter at all !! We all are here because we want to make all > this better. Not because one or other has to commit. It's OK Matt. But I > still see the leak... don't you agree that if the button is pressed twice > we have a memory loss ? > > Bye, > Rafael Fernández López.
I didn't say anything about committing or not committing. No, I don't agree. I agree that there is a misuse of memory, but there is no leak here (there is a difference). We can leave it just the way it is, and it will all work, and the memory will be cleaned up when the account configuration closes. The reason that I don't like your solution is that it turns a non-modal dialog into a modal dialog. If you can change the code so that we still use a non-modal dialog, and then delete the memory when the dialog is closed, I think we should commit that patch. -- Matt _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
