On Wednesday 31 January 2007 06:23, Martijn Klingens wrote: > Nobody? :) > > On Sunday 28 January 2007 02:29, Martijn Klingens wrote: > > Hiya, > > > > Attached is a patch that changes Kopete::Emoticons::emoticonAndPicsList() > > to return *all* emoticons in a QStringList per icon rather than only the > > first. > > > > Apart from being arguably a bit cleaner semantically, the main motivation > > was because this fixes the logic part of MSN's ability to send the > > emoticon theme as custom emoticons to the peer. > > > > Unfortunately the file sending itself seems horribly unreliable, so it > > doesn't work out all that well. (And I have my reservations about the > > fact that it sends PNG -- does Microsoft's own client really understand > > PNG?) > > > > Anyway, the P2P part is something I cannot fix, I just hope Michel can > > help here. I noticed some MSNP2P 500 errors in the debug output, but > > didn't look closer, don't know the protocol. > > > > Is the attached patch (for 3.5 branch) ok to commit? Anyone who can take > > care of porting to 4.0 branch?
oh, you didn't commit already? Go ahead and commit. -- Matt
pgp6nw5rJcLeY.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
