(Another resend, with the attachment left out on purpose. Looks like it gets eaten, still trying to figure out what's going on.)
(Resend, wherever my mail from yesterday went, it's not in my server's outgoing queue and not on the list. Looks like it got eaten.) Please review: On Sunday 11 February 2007, Martijn Klingens wrote: > In my patch to speed up formatStyleKeywords I already mentioned that there > is one much bigger fish: the call to message.plainBody(). > > It is used *ONLY* to determine whether a message is LTR or RTL for bidi > locales. That is a lot of overkill. > > [...] > > The alternative is to add an isRightToLeft() to Kopete::Message that caches > the result. Attached is a patch that does exactly that. It also kills some code duplication between de Message::Private ctor and setBody(). And it rewrites the regexp part of plainBody(). The reason is that with the caching we still need to call plainBody once per message, and even that single call is outrageously expensive. The combined result is that plainBody() is about double as fast as it used to be (the single remaining regexp replace eating 35% of the time) and is also never called more than once. The darn thing is still too slow, but this should at least give ~35% speedup compared to before both optimization patches. Ok to commit to 3.5 branch? -- Martijn What may be done at any time will be done at no time. -Scottish proverb _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
