On Thursday 08 March 2007 04:43, Martijn Klingens wrote: > On Thursday 08 March 2007 02:43, Matt Rogers wrote: > > doSetBody needs to be made private (if it's not already) and needs to > > be marked as internal for Doxygen. Add "@internal" to the > > documentation for that function. > > It is already private (I added that method a few weeks ago), but missed the > @internal, my bad :$ > > > We need to verify that escapedBody does the same thing it did before > > this change and that the output is the same. Please write a unit test > > for that. > > Those can be added to the existing tests for Kopete::Message, saves work :) > > > General questions: > > > > Can we use QTextDocumentFragment or whatever it's called for the > > Message instead of a QTextDocument? My idea was that the messaging > > session would be represented by a QTextDocument and then we just add > > fragments to the chat session document and have it go render it. I > > don't know if it'll work or not, or if it's the best way. It's just > > my idea. > > Are you sure that's a good idea? When new messages arrive it would imply > rebuilding and rerendering the whole HTML, making it slower as chats grow. >
I didn't qualify it with good or bad, just that it was an idea. If it's not a good idea, then we don't do it. Plain and simple. :) > The current incremental addition of HTML (as opposed to full rebuild) seems > pretty much required. (Especially given that there are a few cases that > already do trigger a rebuild, like avatar changes, and those are exactly > the dog slow things I'm trying to optimize...) Now that you describe how it works, it's probably not something we want to do. :) -- Matt
pgpGJrd7boBFx.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
