Hi!

Am Montag 26 März 2007 21:43 schrieb Jason Keirstead:
> I believe the problem is that because in the GPG case the crypto is done by
> a plugin, it is run *after* the history plugin loggs the message. What you
> are doing is you're setting the encrypted message inside the
> Kopete::Message, which will basically mean *none* of the other plugins in
> the chain are ever going to see the plain text:
>
>       ( Line 146 of otrplugin.cpp, in version 0.1: )
>       msg.setBody( encBody, Kopete::Message::RichText );
>
> I think you need to comment out that line... if I understand the code
> correctly the plugin is sending the message out over the wire with the line
> before it, so you should not have to modify the message here, unless that
> is your intention.

Thats not right.:
otrlChatInterface->encryptMessage(  ... ) does not send the Message out. It 
just passes the messagetext to the libotr and returns the encrypted text. 

The only way I see to log the messages is to influence the order the plugins 
are called but I havent found any way to do this so far.

>
> Somewhat unrelated - but it might be a nice feature request to have this as
> optional in the history plugin anyway; I can see lots of reasons why people
> who use the OTR plugin (or GPG plugin) would not want their conversations
> logged, but not care if plain text messages over eg. MSN are logged.
>
> Would be easy to key off of the MessageFormat::Crypted property for this if
> they had "Do not log encrypted chat sessions" checked off in the history
> plugin settings for example. The OTR plugin should probably set this
> property to true.

I agree.
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to