On Friday 25 May 2007 05:50:19 Martijn Klingens wrote: > On Friday 25 May 2007 04:41, Gustavo Pichorim Boiko wrote: > > Is there any special reason for this dialog to be asynchronously called? > > My experience in the years that I worked on Kopete has been that > *everything* should be called asynchronously as long as there's a > possibility of having open network connections that can trigger all kinds > of changes to internal data structures. (Think contacts coming and going > from serverside contact lists for example.) > > Basically the first part of Kopete startup and the last part of shutdown > are the only areas where using sync calls is really safe. To some extent it > is also safe from stuff called directly from main menus and toolbars. > > Under *no* circumstances should sync calls be done from context menus in > the contact list or any other place where contact-related classes will be > in the backtrace.
It is not from context menus, I'm talking about a dialog for choosing the Avatar (the image that will be shown). It could follow what is done on the standard KDE dialogs (including for the file open one which is used already for choosing avatar images in some protocols). A synchronous call fits in the context. And the only thing AvatarSelectorDialog is doing asynchronously is returning the avatar that was choosen in the dialog, so doing it asynchronously does not really make sense from my point of view. Cheers -- Gustavo Pichorim Boiko ----------------------------------- KDE Developer www.kde.org Mandriva Labs www.mandriva.com _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
