On Thursday 02 August 2007 11:17, Dmitry Suzdalev wrote:
> Hello, kopete devs! :-)
>
> While trying to fix a bug that no chatwindow style is picked by default
> (until it get's set explicitely), I tracked it to be wrong KStandardDirs
> usage issue. Let me give you some details.
>
> kopetechatwindowconfig.kcfg specifies that default style path is:
> KStandardDirs::locate("appdata", "styles/Kopete")
>
> and I found that this call returns an empty string even in case
> when "styles/Kopete" directory exists (and it does).
> Also I found that if I append a slash, i.e. try to locate "styles/Kopete/",
> things magically start to work and KStandardDirs returns a valid path.
>
> I asked about this issue on k-c-d and got reply from coolo (who mainains
> KStandardDirs), that this class isn't supposed to be used to find DIRS -
> it's supposed to be used to search for files.
>
> He suggested to put some file in directory that needs to be found and then
> use KStandardDirs::foundResourseDir() method.
>
> This seems to be a valid solution and all others will be more or less hacks
> around standard KStandardDirs usage IMO
>
> Well, I writing this so you, the devs, can discuss what that file might
> look like - will it be a dummy one, or perhaps there's some (meta-)info
> about style that it can contain?
> (for example, in kdegames we use .desktop file to hold various
> svgtheme-related settings for our games aka number of animation frames,
> author's name & email etc etc)
>
> Perhaps you see the other way around the problem (not putting file in each
> style's dir), but then we should go away from using KStandardDirs I guess.
>
> Me and Will agreed that I should write here so you can discuss all these
> things.
>
> Btw, thanks Will, for asking my perhaps silly kopete-related questions :-)
>
> Cheers,
> Dmitry.

Thanks for finding this. :)

Let's create a .desktop file that contains the name of the default style to 
use, name it something, find it, and then use that to get the default style 
to use rather than relying on something hard coded. 
-- 
Matt

Attachment: pgpZfRCTZIcLA.pgp
Description: PGP signature

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to