Matt Rogers schrieb: > On Monday 01 October 2007 09:55:33 am Tom Patzig wrote: > >> Hi all, >> >> JFYI, i commented out some redundant code in videodevicepool.cpp (3.5 >> branch). >> The needless block cause crashes, when searching for video devices, >> because m_current_device is left uninitialized. >> >> Tom >> > > This commit caused crashes for other people though. Why can't you just > initialize m_current_device? > -- > Matt The code block isn't not only redundant, it is also wrong. Because it ever returns EXIT_FAILURE, although the device may be succesfully opened. The case, that there is no valid device found is handled above and returns EXIT_FAILURE. We have had a bug report on this issue and the the reporter mentioned that it workes now (without that code block). Cláudio, any comments?
Regards, Tom -- -------------------------------------------- Tom Patzig <[EMAIL PROTECTED]> Novell / SUSE SUSE LINUX Products GmbH - Nürnberg - AG Nürnberg - HRB 16746 - GF: Markus Rex _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
