On Friday 05 October 2007 21:42:44 Alexander Rieder wrote:
> Hi,
> Today I was bored, so I decided to do something easy. I removed the
> Qt3Support dependencies from the KabcExportWizard and ported it to
> KAssistantDialog.

Looks like a nice improvement compared to the Qt3 one :-)

> Is it okay if I commit these changes?

I think there slipped in some errors when porting the item flags. In the 
constructor when filling the contact list for page 2, it should be 

if ( mc->metaContactId().contains(':') )
{
        lvi->setCheckState( Qt::Checked );
        lvi->setFlags( Qt::ItemIsEnabled | Qt::ItemIsUserCheckable );
}
else
{
        lvi->setText( lvi->text() + alreadyIn );
        lvi->setFlags( 0 );
}

(Make items not in addressbook user checkable and disable others by settings 
flags to 0).

In slotSelectAll() there should be

if ( item->flags() & Qt::ItemIsEnabled)
        item->setCheckState( Qt::Checked );

(Only check enabled items).

Besides that everything seems to work well. 

Regards,
Dennis

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to