On Sat, 12 Jan 2008 22:57:11 +0100, Olivier Goffart <[EMAIL PROTECTED]> wrote:
> Le samedi 12 janvier 2008, Roman Jarosz a écrit : >> On Sat, 12 Jan 2008 21:56:33 +0100, Olivier Goffart <[EMAIL PROTECTED]> > wrote: > >> > Also, I did not check carefully, but it seems to me that some class >> > should not belong to libkopete, but be in the application instead. >> > Please ask yourself "is that class really required to be in libkopete" >> > for every class you add. Remember that if it's in libkopete, we will >> > havee to maintain compatibility if ever we reach Kopete 1.0 >> >> I know that StatusRootAction, StatusGroupAction, StatusAction and >> StatusEditAction shouldn't be in libkopete but we need them in >> OnlineStatusManager::createAccountStatusActions(...) to build status menu >> for accounts and I don't see an easy and sensible solution for it. > > Then move them to libkopete/private Ok >> > We also, in libkopete, have Kopete::Status* and Kopete::OnlineStatus* >> > classes. I think i understand the difference (Status is a generic >> > container for a metacontact/identity), and OnlineStatus is for managing >> > the protocol status of subcontact/accounts and their icon) >> > The same word is used for two different thing. a rename is required. >> > I will think about suggestions. :-) >> >> If you are talking about Kopete::Status::StatusItem, Kopete::Status::Status >> andKopete::Status::StatusGroup then this classes are used to build status >> tree in StatusManager and hold all necessary data e.g. title, category, >> message, uid. > > I mean that the name "Status" is probably too short, and may be confused > with "OnlineStatus" which is AFAIK very different. Yeh and we probably should kill the namespace too, awaiting suggestions :) _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
