Le mardi 15 janvier 2008, Olivier Goffart a écrit : > Le mardi 15 janvier 2008, Igor Janssen a écrit : > > Hello. > > This patch implements better XMPP XEPs support: > > XEP-0004 Data Forms (QWidget render) > > XEP-0050 Ad-Hoc Commands > > XEP-0055 Jabber Search (+ x:data) > > XEP-0077: In-Band Registration (+ x:data) > > And start work on > > XEP-0060: Publish-Subscribe > > XEP-0107: User Mood > > + some GUI improvements (service dialog and xml console) > > If nobody objects I want commit and continue work on svn. Comments and > > feature requests are welcome too. > > Waw, big patch :-) > I would have prefered a separate patch for each features... > But i guess it's too late now. (unless you used git or some smart scm ?) > > Have you some screenshot of the changes so i can visualize them better. > > > I have not read the whole patch yet, but is saw some usage of QDialog. > Using KDialog is probably better. > > It is also nice you managed to do everithing without patching iris.
More comments: - JabberMoodAction is not required, use QAction::data or QObject::property - Why didn't you use the existing JabberFormTranslator for xdata? - Add your name on top of files you add or make non trivial changes. - dlgJabberSendRaw should be removed if not used anymore. - why did you change the convention of dlgJabberFoo ? - inheriting from the ui file is the Qt3 way. I much prefer the method described here : http://doc.trolltech.com/4.3/designer-using-a-component.html#the-single-inheritance-approach so everithing doesn't need to include the generated header file. Otherwhise it looks good. Thanks. Have you a svn account ?
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
