On Monday 21 January 2008 10:28:48 you wrote: > On Monday 21 January 2008, Matt Rogers wrote: > > On Sun, Jan 20, 2008 at 10:07:15PM +0000, Oleg Girko wrote: > > > Hi! > > > > > > The patch attached to this message fixes 2 annoying inconveniences in > > > Kopete ICQ authorisation request dialog. > > > > > > 1. Set wordWrap property of lblRequestReason to true. > > > > > > The request reason string can be very long, and without wordWrap set to > > > true can lead to ridiculously wide dialog window. > > > > > > 2. Added "Contact" menu button which invokes contact menu. > > > > > > When authorisation request comes, the first question which comes to > > > mind is "Who is that?". Without this patch there are only two ways to > > > get requestor's info: use search function of "Add contact" and enter > > > UIN manually (conveniently, you can't select UIN from text in dialog) > > > or open web browser and enter manually "http://www.icq.com/UIN";). Both > > > ways are very inconvenient. > > > > > > With this patch a temporary contact is added on arrival of > > > authorisation request (the same way as when a message from unknown > > > contact is received). This contact's context menu can be invoked from > > > "Contact" button. > > > > > > This is just a minor patch to relieve user interface pain in ICQ > > > protocol support only. The long-term solution should be a major > > > refactoring of event handling in Kopete to handle authorisation > > > requests and other special messages the way uniform with regular > > > messages. > > > > > > Popping up dialogs is acceptable only as a result of user's action, not > > > on asynchronous events like authorisation requests. All asynchronous > > > events should lead to asynchronous notifications (blinking of tray > > > icon, blinking of icon in contact list, possibly notification popup > > > near the tray icon which always disappears in 10 seconds if user does > > > not click it). > > > > > > The real window should open only as a result of user's interaction: > > > when user clicks on a notification popup or blinking icon. If the event > > > is a regular message, the chat window should open. If it is an > > > authorisation request, an authorisation dialog should open. > > > > > > -- Oleg Girko, http://www.infoserver.ru/~ol/ > > > > I'm not sure that I like the use of a temporary contact for this. Why > > not just add a option that allows the person to view the contact's info > > right from the dialog box? > > Why not? Temporary contact adds more flexibility. For example, before > authorising somebody, you could want to send this person a message "Who are > you?" if you find user info incomplete or insufficient. Or you could want > to add this contact to your contact list without authorising. Or you could > want to send a big file containing an indecent picture if this person > annoys you with authorisation requests too often. :-) So the full contact > menu is very useful at this stage. > > The only problem with temporary contacts is that they do not disappear > after you finished your interaction and decided not to add this contact to > your contact list. This is also important usability issue which should be > addressed separately. >
This usability issue is exactly why I don't like the use of a temporary contact. But go ahead and commit, and we can address that issue separately. -- Matt
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
