----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://matt.rogers.name/r/61/#review48 -----------------------------------------------------------
Ship it! Looks fine. Please commit. - Matt On 2008-02-03 16:28:36, Roman Jarosz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://matt.rogers.name/r/61/ > ----------------------------------------------------------- > > (Updated 2008-02-03 16:28:36) > > > Review request for Kopete. > > > Summary > ------- > > It's because OnlineStatusIconEngine from kopeteonlinestatus.cpp wants to use > protected > functions in kopeteonlinestatusmanager.h but we can't declare > OnlineStatusIconEngine as > a friend of Kopete::OnlineStatusManager. > > I had to move the OnlineStatusIconEngine to kopeteonlinestatus.h so > Kopete::OnlineStatusManager > can see it. I've also tried to move OnlineStatusIconEngine from > OnlineStatus::Private > and leave it in kopeteonlinestatus.cpp but it didn't work. > > The commit that broke it was 760807. > Btw I couldn't test it so anybody with gcc 3 or Mac/Win please test it. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/kopeteonlinestatus.h > trunk/KDE/kdenetwork/kopete/libkopete/kopeteonlinestatus.cpp > trunk/KDE/kdenetwork/kopete/libkopete/kopeteonlinestatusmanager.h > > Diff: http://matt.rogers.name/r/61/diff > > > Testing > ------- > > > Thanks, > > Roman > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
