On Mon, 04 Feb 2008 20:43:21 +0100, Olivier Goffart <[EMAIL PROTECTED]> wrote:

> Le dimanche 3 février 2008, Roman Jarosz a écrit :
>> Hi,
>>
>> there were some reports on irc that Kopete can't be compiled on Mac/Win and
>> with gcc 3.
>>
>> It's because OnlineStatusIconEngine from kopeteonlinestatus.cpp wants to
>> use protected functions in kopeteonlinestatusmanager.h but we can't declare
>> OnlineStatusIconEngine as a friend of Kopete::OnlineStatusManager.
>>
>> I had to move the OnlineStatusIconEngine to kopeteonlinestatus.h so
>> Kopete::OnlineStatusManager can see it. I've also tried to move
>> OnlineStatusIconEngine from OnlineStatus::Private and leave it in
>> kopeteonlinestatus.cpp but it didn't work.
>
> Please don't make it public API.
> Why can't you keep it in the cpp fila and declare it with
> class OnlineStatucIconEngine;  ?

I've tried that, but It won't compile on gcc4.

>
>> The commit that broke it was 760807.
>
> oops, that's mine. sorry
>
>> Btw I couldn't test it so anybody with gcc 3 or Mac/Win please test it.
>
> Me neither.
>
> 



_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to