-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/171/
-----------------------------------------------------------

(Updated 2008-02-23 10:21:47.197447)


Review request for Kopete.


Summary
-------

This is a patch that resizes the main window automatically, so that it nicely 
fits the size of the contact list tree. This is set up as an off-by-default 
option. The user can specify a maximum size, so that it never gets bigger than 
one's screen, and also a minimum size.

The way this is done is by reevaluating the needed size for the contact list 
every X seconds (once again, user may specify). The timer will not run if the 
contact list is not maximized. Also, it will not resize if the user's cursor is 
inside the main window, as this would likely cause undue frustration.

Advantages: - Always a nicely presented main window.
            - Keep up with feature sets in competitors (some of them already 
have this).

Disadvantages: - If window is visible to user, it is distracting to see it 
resizing spontaneously.
               - Repeatedly firing timer may interfere with sleep mechanisms on 
systems.
               - Repeatedly firing timer adds CPU usage to an otherwise idle 
process. Bloat is BAD.

Of course, this is all off by default, and even if the setting is enabled, it 
only takes effect when the main window is maximized.


This addresses bug 154955.


Diffs
-----

  
trunk/KDE/kdenetwork/kopete/kopete/config/appearance/appearanceconfig_advanced.ui
  trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.h
  trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp
  trunk/KDE/kdenetwork/kopete/libkopete/kopeteappearancesettings.kcfg
  trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistview.h
  trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistviewitem.h
  trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistviewitem.cpp

Diff: http://mattr.info/r/171/diff


Testing
-------

works for me after during a few minutes of testing


Screenshots
-----------

Config options rev. 2
  http://mattr.info/r/171/s/19/


Thanks,

Charles

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to